Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed intensity/parallel values should be respected on retry. #3580

Closed
karol-kokoszka opened this issue Sep 14, 2023 · 3 comments · Fixed by #3586
Closed

Changed intensity/parallel values should be respected on retry. #3580

karol-kokoszka opened this issue Sep 14, 2023 · 3 comments · Fixed by #3586
Assignees
Labels
Milestone

Comments

@karol-kokoszka
Copy link
Collaborator

If intensity/parallelism values are changed for a running repair, a retry of a failure of that repair should inherit the parallelism/intensity altered settings until that run successfully completes or is started with --no-continue.

As per https://github.com/scylladb/scylla-enterprise/issues/3419

@karol-kokoszka karol-kokoszka added this to the 3.2.2 milestone Sep 14, 2023
@Michal-Leszczynski
Copy link
Collaborator

Do we want change sctool repair control to also permanently change parallel/intensity for the next task runs, or only for the current run?

@karol-kokoszka
Copy link
Collaborator Author

We just want to make sure that the current task run is affected.
https://manager.docs.scylladb.com/stable/sctool/repair.html#reschedule-a-repair
The CLI above can be used to update the task permanently.

@Michal-Leszczynski Michal-Leszczynski self-assigned this Sep 24, 2023
@Michal-Leszczynski
Copy link
Collaborator

My proposition:

Add intensity and parallel to scylla_manager.repair_run. This way we can prioritize params from DB (when we continue previous run) over standard params (used when running from scratch). This means that params set by repair control will be respected in all runs continuing the run when they were set (e.g. params will be respected when pausing/resuming task).

Side benefit of this solution is that we would be able to display effective parallel and intensity of a already finished task (right now we display those params only for currently running tasks, because we lack this info in DB).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants