Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove flakiness of TestServiceRepairResumeAllRangesIntegration for Tablets #3834

Closed
Michal-Leszczynski opened this issue May 6, 2024 · 0 comments · Fixed by #3839
Closed

Remove flakiness of TestServiceRepairResumeAllRangesIntegration for Tablets #3834

Michal-Leszczynski opened this issue May 6, 2024 · 0 comments · Fixed by #3839
Assignees
@Michal-Leszczynski
Labels
bug Something isn't working repair testing

Comments

@Michal-Leszczynski
Copy link
Collaborator

TestServiceRepairResumeAllRangesIntegration might fail when executed against tablet env:

2024-05-02T15:32:43.4828588Z     service_repair_integration_test.go:1095: Overall redundant ranges 39
2024-05-02T15:32:43.4829937Z     service_repair_integration_test.go:1097: Expected less redundant token ranges than 39
2024-05-02T15:32:43.4831372Z --- FAIL: TestServiceRepairResumeAllRangesIntegration (91.77s)

As tablet tables are always repaired from scratch when repair is restarted (5 repairs * 8 tablets in table ~ 40 re-repaired ranges).
The test should be changed so that it takes tablets into consideration.
@Michal-Leszczynski Michal-Leszczynski added bug Something isn't working repair testing labels May 6, 2024
@Michal-Leszczynski Michal-Leszczynski self-assigned this May 6, 2024
This was referenced May 6, 2024
Merged
Closed
Michal-Leszczynski added a commit that referenced this issue May 8, 2024
@Michal-Leszczynski
fix(repair_test): adjust TestServiceRepairResumeAllRangesIntegration …
e28b512 
…for tablets

Fixes #3834
@Michal-Leszczynski Michal-Leszczynski mentioned this issue May 8, 2024
Merged
Michal-Leszczynski added a commit that referenced this issue May 8, 2024
@Michal-Leszczynski
fix(repair_test): adjust TestServiceRepairResumeAllRangesIntegration …
346c478 
…for tablets

Fixes #3834
Michal-Leszczynski added a commit that referenced this issue May 8, 2024
@Michal-Leszczynski
fix(repair_test): adjust TestServiceRepairResumeAllRangesIntegration …
6756e49 
…for tablets

Fixes #3834
karol-kokoszka pushed a commit that referenced this issue May 8, 2024
@Michal-Leszczynski @karol-kokoszka
fix(repair_test): adjust TestServiceRepairResumeAllRangesIntegration …
815e978 
…for tablets

Fixes #3834
karol-kokoszka pushed a commit that referenced this issue May 9, 2024
@Michal-Leszczynski @karol-kokoszka
fix(repair_test): adjust TestServiceRepairResumeAllRangesIntegration …
aa02aad 
…for tablets

Fixes #3834
karol-kokoszka pushed a commit that referenced this issue May 9, 2024
@Michal-Leszczynski @karol-kokoszka
fix(repair_test): adjust TestServiceRepairResumeAllRangesIntegration …
f362a86 
…for tablets

Fixes #3834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Michal-Leszczynski Michal-Leszczynski

Labels
bug Something isn't working repair testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make gh actions tests green scylladb/scylla-manager
1 participant
@Michal-Leszczynski