Test enterprise nightly #3843
Merged
Test enterprise nightly #3843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to this point we didn't specifically set tombstone_gc mode in tests and expected it to be 'timeout'. Since tablet tables need to have tombstone_gc 'repair', we should change the default expectation to it. Note that this 'assumption' should be removed in the future in favor of something more robust.
Michal-Leszczynski
force-pushed
the
ml/test-enterprise-nightly
branch
2 times, most recently
from
7c64299
to
f702253
Compare
Ent Scylla versions contain additional table "dicts" which cannot be found in OSS Scylla, so it should be excluded when comparing GetTarget output with golden files.
Michal-Leszczynski
force-pushed
the
ml/test-enterprise-nightly
branch
9 times, most recently
from
89e2fb8
to
801b9e2
Compare
|
@karol-kokoszka as expected (see #3869), new restore user test is failing for Scylla nightly and will be failing for Scylla 6.0 in general. The PR is ready for review! |
karol-kokoszka
approved these changes
May 28, 2024
Michal-Leszczynski
force-pushed
the
ml/test-enterprise-nightly
branch
2 times, most recently
from
aec76b3
to
986d708
Compare
…on_test.go This commit refactors restore_test helper functions and extracts them in helper_integration_test.go. They will be used for a improved test framework in the future commits. It also gets rid of validateTable, as it was introduced as a workaround for issues with COUNT(*), but is no longer needed.
TestHelper is a reimplementation of restoreTestHelper which wasn't well-designed. It removes a lot of boilerplate from test setup and also allows for more flexibility.
TestRestoreTablesUserIntegration is implemented with new test framework (testHelper). It checks if we can log in as a restored user and use their permissions.
TestRestoreTablesNoReplicationIntegration is rewritten so that it's prettier, and it works well with new default tombstone_gc mode repair.
Starting with Scylla 6.0, system_auth is moved to system/system_auth_v2 and is handled by raft. New clusters won't have the old system_auth tables, so the tests should be adjusted accordingly.
Repair ignore hosts test stops and starts Scylla service on a node, and it could happen that this node is not fully responsive when the next test is already running.
Michal-Leszczynski
force-pushed
the
ml/test-enterprise-nightly
branch
from
986d708
to
4213a28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new restore test framework (
testHelper) and (with its help) implements a functional test for restoring a user (TestRestoreTablesUserIntegration). It also rewritesTestRestoreTablesNoReplicationIntegration.It also:
Fixes #3833