Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logged/unlogged batches graphs #2081

Closed
vladzcloudius opened this issue Oct 12, 2023 · 1 comment · Fixed by #2112
Closed

Add logged/unlogged batches graphs #2081

vladzcloudius opened this issue Oct 12, 2023 · 1 comment · Fixed by #2112
Assignees

Comments

@vladzcloudius
Copy link
Contributor

Please make sure that this is a feature request.
Any scylla version has relevant metrics.
A dashboard that should have new graphs is "Scylla CQL"

Describe the feature and the current behavior/state.
Today we don't have a graph that would show the information about the type (logged or unlogged) of BATCH CQL statements that were issued.

Metrics that count logged/unlogged batches are these: scylla_cql_batches_pure_logged and scylla_cql_batches_pure_unlogged correspondingly.

The usage of logged batches is already a big red flag and in addition to having a graph that counts them we probably want to have something about them on the "Overview" dashboard as well.

Who will benefit with this feature?
Everybody

@amnonh
Copy link
Collaborator

amnonh commented Nov 2, 2023

I'll add metrics to the CQL dashbaord, about the overview, it's just one of this features (we have a few of them in the cql optimization section).
It's something the user can use, but we advice against it. like allow filtering, or non paged queries.
That used to be the advisor section, but we end up removing it as it caused more confusion than help

@amnonh amnonh added this to the Monitoring 4.6 milestone Nov 2, 2023
amnonh added a commit to amnonh/scylla-grafana-monitoring that referenced this issue Nov 6, 2023
This patch split the batch statement into two panels, one for the logged
and one for the unlogged.

Fixes scylladb#2081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants