Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.6.0 - By Instance, doesn't work on any of the dashboards #2138

Closed
fruch opened this issue Dec 25, 2023 · 3 comments · Fixed by #2140
Closed

4.6.0 - By Instance, doesn't work on any of the dashboards #2138

fruch opened this issue Dec 25, 2023 · 3 comments · Fixed by #2140
Assignees
@amnonh
Labels
bug
Milestone
Monitoring 4.6

Comments

@fruch
Copy link
Contributor

fruch commented Dec 25, 2023

Installation details
Panel Name: All panel that can show data by instance
Dashboard Name: Os Metric (but it apply to all other dashboards)

Scylla-Monitoring Version: 4.6
Scylla-Version: 2024.1-rc2

all of the dashboards that need to show data per instance, so all of the data together:
image

example of such run:

hydra investigate show-monitor 065fe747-1a6d-4f96-8dad-2b0648201bd3
``

here is example of such query:

sum(node_memory_MemAvailable_bytes{instance="[[node]]",cluster="$cluster|$^", dc="$dc"}) by ([[by]])/sum(node_memory_MemTotal_bytes{instance="[[node]]",cluster="$cluster|$^", dc="$dc"}) by ([[by]])

![image](https://github.com/scylladb/scylla-monitoring/assets/340979/d85ad58e-4ef8-499d-b287-da676dde4a34)


replacing it `[[by]]` with `instance`

sum(node_memory_MemAvailable_bytes{instance="[[node]]",cluster="$cluster|$^", dc="$dc"}) by ([[by]])/sum(node_memory_MemTotal_bytes{instance="[[node]]",cluster="$cluster|$^", dc="$dc"}) by (instance)


![image](https://github.com/scylladb/scylla-monitoring/assets/340979/d5d3d0a7-d765-48ab-b81b-6451cf162bcd)
@fruch fruch added the bug label Dec 25, 2023
@amnonh
Copy link
Collaborator

amnonh commented Dec 25, 2023

@fruch I still cannot reproduce, this is how the OS dashboard looks like:
image

@fruch
Copy link
Contributor Author

fruch commented Dec 25, 2023

I still see it on any run uses monitoring 4.6.0

image

as you can see the query is using capital Instance and doesn't sure what I would expect.

fruch added a commit to fruch/scylla-monitoring that referenced this issue Dec 25, 2023
@fruch
grafana: fix by variable
33caca4 
seems like custom variable is not full controlled by the query
paramter, and you need to feed it a comma seperated with `key : value`
for it to work as expectred, and the rest of the data we feed in `option`
does really work anymore

Closes: scylladb#2138
@fruch fruch mentioned this issue Dec 25, 2023
Closed
@amnonh
Copy link
Collaborator

amnonh commented Dec 25, 2023

Because I'm using your example, I assume this is due to os/browser differences.

amnonh pushed a commit that referenced this issue Dec 26, 2023
@fruch @amnonh
grafana: fix by variable
ccd3c6a 
seems like custom variable is not full controlled by the query
paramter, and you need to feed it a comma seperated with `key : value`
for it to work as expectred, and the rest of the data we feed in `option`
does not really work anymore

Closes: #2138
@amnonh amnonh mentioned this issue Dec 26, 2023
Merged
amnonh pushed a commit that referenced this issue Dec 26, 2023
@fruch @amnonh
grafana: fix by variable
90d2156 
seems like custom variable is not full controlled by the query
paramter, and you need to feed it a comma seperated with `key : value`
for it to work as expectred, and the rest of the data we feed in `option`
does not really work anymore

Closes: #2138
(cherry picked from commit ccd3c6a)
@amnonh amnonh added this to the Monitoring 4.6 milestone Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amnonh amnonh

Labels
bug
Projects
None yet
Milestone
Monitoring 4.6
2 participants
@fruch @amnonh