Wrong port number for node manager agents in prometheus/prometheus.consul.yml.template when using Docker

[jeftadlvw]

Installation details

• Scylla-Monitoring Version: master
• Scylla-Version: latest (5.4.6)
• Toy cluster with local docker containers

When provisioning a prometheus configuration using

./prometheus-config.sh -L <manager ip> --compose

and starting the monitoring stack with docker compose, Prometheus is unable to connect to each node's manager agent. This is because the consul-template sets the wrong port for the manager agent:

scylla-monitoring/prometheus/prometheus.consul.yml.template

Line 196 in ba445e1

replacement: '${1}:56090'

I used the Dockerfile provided by the documentation to create an image that contains a manager agent (see https://manager.docs.scylladb.com/stable/docker/index.html). In that image, the default port for the manager is 5090. So it should be the default port in the configuration too (instead of 56090).

IMO, using the -L together with --compose should also be documented.

Useful information:

• Source code references are on commit ba445e1c0458741d377b08c16b45d05f61b98279, which, at the time of writing, is the latest commit to master