Use compose to start the monitoring stack #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amnonh I expected to see the doc part of this PR, including adding compose as a prereqieust |
Done, please have a look |
mykaul
reviewed
Dec 3, 2023
| ;; | ||
| (--auto-restart) DOCKER_PARAM="$DOCKER_PARAM restart: unless-stopped\n" | ||
| ;; | ||
| (--victoria-metrics) VICTORIA_METRICS="1" |
There was a problem hiding this comment.
I wonder if this still works?
There was a problem hiding this comment.
It will not under compose, I'm not testing it with our regular monitoring stack, as it's all experimental, I wanted to start with an initial commit and make changes if I'll see that it's in use.
There was a problem hiding this comment.
I've added victoria metrics support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series adds an experimental option to use docker compose to start the monitoring stack.
the
--composecommand line option to start all will create a compose file and a .env file.That can be used with docker-compose up to start the stack.
Fixes #1073