Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add templates for network and disk #84

Merged
merged 2 commits into from
Nov 27, 2016
Merged

Add templates for network and disk #84

merged 2 commits into from
Nov 27, 2016

Conversation

amnonh
Copy link
Collaborator

@amnonh amnonh commented Nov 17, 2016

No description provided.

@tzach
Copy link
Contributor

tzach commented Nov 20, 2016

Nice!
As simple, yet very useful update

Please add the selected disk, interface to the chart title.
For example:

eth0 Interface Rx Packets

current_disk, current_if terms are not ver clear.
How about monitor_disk and monitor_network_interface?
(what is "if"?)

@tzach
Copy link
Contributor

tzach commented Nov 27, 2016

Thank Amnon looks good.

@tzach tzach merged commit cb13d61 into scylladb:master Nov 27, 2016
@tzach tzach mentioned this pull request Nov 27, 2016
Closed
@tzach tzach mentioned this pull request Feb 23, 2017
Closed
@amnonh amnonh deleted the disk_template branch March 1, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amnonh @tzach