Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Scylla Manager integration E2E test for error propagation for invalid tasks and invalid updates #1908

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Add a Scylla Manager integration E2E test for error propagation for invalid tasks and invalid updates #1908

merged 1 commit into from
Jun 6, 2024

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Apr 30, 2024 •
edited

Description of your changes: This PR adds an e2e test covering Scylla Manager task status error propagation for newly created, invalid tasks. The purpose of this is to secure a baseline correctness coverage. It also moves the logic checking error propagation for invalid updates to valid tasks away from the existing e2es to to this one.

Which issue is resolved by this Pull Request:
Resolves #1907

Prerequisites #1850

/kind feature
/priority important-longterm

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@scylla-operator-bot scylla-operator-bot bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 30, 2024
@scylla-operator-bot scylla-operator-bot bot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 30, 2024
@rzetelskik rzetelskik changed the title Add a Scylla Manager integration E2E test for error propagation for invalid tasks [WIP] Add a Scylla Manager integration E2E test for error propagation for invalid tasks Apr 30, 2024
@rzetelskik rzetelskik mentioned this pull request May 1, 2024
Merged
@rzetelskik rzetelskik force-pushed the scylla-manager-e2e-invalid-tasks branch from 4519883 to dd8fcd7 Compare May 15, 2024 13:37
@rzetelskik rzetelskik marked this pull request as ready for review May 15, 2024 13:38
@rzetelskik rzetelskik changed the title [WIP] Add a Scylla Manager integration E2E test for error propagation for invalid tasks Add a Scylla Manager integration E2E test for error propagation for invalid tasks May 15, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2024
@rzetelskik rzetelskik force-pushed the scylla-manager-e2e-invalid-tasks branch from dd8fcd7 to 8c166df Compare May 15, 2024 14:09
@rzetelskik
Copy link
Member Author

/cc zimnx
ready for review

zimnx
zimnx approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign tnozicka

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@zimnx zimnx mentioned this pull request May 16, 2024
Merged
tnozicka
tnozicka approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@rzetelskik
Copy link
Member Author

/hold
#1742 (comment)

@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2024
@rzetelskik rzetelskik force-pushed the scylla-manager-e2e-invalid-tasks branch from 8c166df to 5af3109 Compare May 21, 2024 10:24
@scylla-operator-bot scylla-operator-bot bot removed the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@rzetelskik rzetelskik changed the title Add a Scylla Manager integration E2E test for error propagation for invalid tasks [WIP] Add a Scylla Manager integration E2E test for error propagation for invalid tasks May 21, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2024
@rzetelskik rzetelskik force-pushed the scylla-manager-e2e-invalid-tasks branch from 5af3109 to 204d9b8 Compare May 21, 2024 13:11
@rzetelskik
Copy link
Member Author

Requires #1933.

@rzetelskik rzetelskik changed the title [WIP] Add a Scylla Manager integration E2E test for error propagation for invalid tasks [WIP] Add a Scylla Manager integration E2E test for error propagation for invalid tasks and invalid updates May 22, 2024
@rzetelskik rzetelskik force-pushed the scylla-manager-e2e-invalid-tasks branch 2 times, most recently from 6da90c3 to f1f0ae1 Compare May 22, 2024 12:12
@rzetelskik
Copy link
Member Author

Let's have #1742 land first since these two share some code.
/hold

@rzetelskik rzetelskik changed the title [WIP] Add a Scylla Manager integration E2E test for error propagation for invalid tasks and invalid updates Add a Scylla Manager integration E2E test for error propagation for invalid tasks and invalid updates May 22, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2024
@scylla-operator-bot scylla-operator-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2024
@rzetelskik rzetelskik force-pushed the scylla-manager-e2e-invalid-tasks branch from f1f0ae1 to 2fa26a9 Compare June 5, 2024 11:10
@scylla-operator-bot scylla-operator-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2024
@rzetelskik rzetelskik changed the title Add a Scylla Manager integration E2E test for error propagation for invalid tasks and invalid updates [WIP] Add a Scylla Manager integration E2E test for error propagation for invalid tasks and invalid updates Jun 5, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2024
@rzetelskik rzetelskik force-pushed the scylla-manager-e2e-invalid-tasks branch from 2fa26a9 to 8ec06d6 Compare June 5, 2024 13:10
@rzetelskik
Copy link
Member Author

/hold cancel

@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

scylla-operator-bot bot commented Jun 5, 2024 •
edited

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 8c166df link true /test e2e-gke-release-script-latest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rzetelskik
Copy link
Member Author

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 8c166df link true /test e2e-gke-release-script-latest
ci/prow/e2e-gke-parallel 8ec06d6 link true /test e2e-gke-parallel
Full PR test history. Your PR dashboard.

https://prow.scylla-operator.scylladb.com/view/gs/scylla-operator-prow/pr-logs/pull/scylladb_scylla-operator/1908/pull-scylla-operator-master-e2e-gke-parallel/1798341703963250688#1:test-build-log.txt%3A1466
unrelated
/retest

@rzetelskik
Copy link
Member Author

/cc zimnx
please review, code changed due to #1742 (comment)

@scylla-operator-bot scylla-operator-bot bot requested a review from zimnx June 5, 2024 14:12
@rzetelskik rzetelskik changed the title [WIP] Add a Scylla Manager integration E2E test for error propagation for invalid tasks and invalid updates Add a Scylla Manager integration E2E test for error propagation for invalid tasks and invalid updates Jun 5, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2024
zimnx
zimnx approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updates.
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit 0e803d3 into scylladb:master Jun 6, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@tnozicka tnozicka tnozicka approved these changes

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend Scylla Manager integration e2e coverage with error propagation testing
3 participants
@rzetelskik @zimnx @tnozicka