-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Scylla Manager integration E2E test for error propagation for invalid tasks and invalid updates #1908
Add a Scylla Manager integration E2E test for error propagation for invalid tasks and invalid updates #1908
Conversation
Skipping CI for Draft Pull Request. |
4519883
to
dd8fcd7
Compare
dd8fcd7
to
8c166df
Compare
/cc zimnx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/assign tnozicka
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/hold |
8c166df
to
5af3109
Compare
5af3109
to
204d9b8
Compare
Requires #1933. |
6da90c3
to
f1f0ae1
Compare
Let's have #1742 land first since these two share some code. |
f1f0ae1
to
2fa26a9
Compare
2fa26a9
to
8ec06d6
Compare
/hold cancel |
@rzetelskik: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cc zimnx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updates.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0e803d3
into
scylladb:master
Description of your changes: This PR adds an e2e test covering Scylla Manager task status error propagation for newly created, invalid tasks. The purpose of this is to secure a baseline correctness coverage. It also moves the logic checking error propagation for invalid updates to valid tasks away from the existing e2es to to this one.
Which issue is resolved by this Pull Request:
Resolves #1907
Prerequisites #1850
/kind feature
/priority important-longterm