Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage TLS certificates #1021

Merged
merged 2 commits into from Oct 31, 2022
Merged

Manage TLS certificates #1021

merged 2 commits into from Oct 31, 2022

Conversation

tnozicka
Copy link
Member

@tnozicka tnozicka commented Aug 29, 2022

Description of your changes:
This PR adds a control loop to ScyllaCluster controller that will automatically create both serving and client TLS certificates. This will be added to all ScyllaClusters but as it is a big change the feature is disabled by default and can be enabled with a feature gate flag --feature-gates=AutomaticTLSCertificates=true on the scylla operator deployment. In the future CQL over TLS will become the default and the bare CQL will be disabled by default for security reasons. There is still a long way there though.

Which issue is resolved by this Pull Request:
Resolves #256

TODO:

@tnozicka tnozicka added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 29, 2022
@tnozicka tnozicka added this to the v1.8 milestone Aug 29, 2022
@tnozicka tnozicka requested a review from zimnx September 16, 2022 12:14
@tnozicka tnozicka changed the title [WIP] Manage TLS certificates Manage TLS certificates Oct 18, 2022
@tnozicka tnozicka requested a review from zimnx October 18, 2022 13:25
fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request Oct 19, 2022
enabling the new feature flag, to start flushing out
what else would be need in SCT

Ref: scylladb/scylla-operator#1021
fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request Oct 19, 2022
enabling the new feature flag, to start flushing out
what else would be need in SCT

Ref: scylladb/scylla-operator#1021
test/e2e/utils/config.go Show resolved Hide resolved
test/e2e/utils/helpers.go Show resolved Hide resolved
test/e2e/utils/helpers.go Outdated Show resolved Hide resolved
pkg/controllerhelpers/error.go Outdated Show resolved Hide resolved
pkg/controller/scyllacluster/sync_certs.go Outdated Show resolved Hide resolved
fruch added a commit to scylladb/scylla-cluster-tests that referenced this pull request Oct 30, 2022
enabling the new feature flag, to start flushing out
what else would be need in SCT

Ref: scylladb/scylla-operator#1021
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zimnx zimnx merged commit 23e9519 into scylladb:master Oct 31, 2022
@tnozicka tnozicka deleted the tls branch October 31, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Encryption in Transit - Client to Node
4 participants