Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E for cluster connection via Ingress #1076

Merged
merged 3 commits into from
Oct 3, 2023
Merged

E2E for cluster connection via Ingress #1076

merged 3 commits into from
Oct 3, 2023

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Oct 26, 2022 •
edited

E2E test validating whether clients can connect to ScyllaDB cluster via CQL Connection Config using Ingresses.

Test binary is extended with three parameters:

  • --ingress-controller-address - address allowing to connect to deployed proxy.
  • --ingress-controller-ingress-class-name - must match the deployed ingress controller class.
  • --ingress-controller-custom-annotations - haproxy requires special annotation to enable passthrough mode, it can be configured via this parameter.

Fixes #1015

@zimnx zimnx force-pushed the mz/ingress-e2e branch 9 times, most recently from 164b07c to c7f8960 Compare October 31, 2022 15:22
@zimnx zimnx force-pushed the mz/ingress-e2e branch 3 times, most recently from 2a3854a to 7cf670a Compare November 4, 2022 08:43
@zimnx zimnx added this to the v1.8 milestone Nov 4, 2022
@zimnx zimnx added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 4, 2022
fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request Nov 7, 2022
@fruch
feature(k8s-serverless): deploy ingress (sni_proxy)
ea189e2 
base on the examples from:
scylladb/scylla-operator#1076
@fruch fruch mentioned this pull request Nov 7, 2022
Closed
7 tasks
fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request Nov 7, 2022
@fruch
feature(k8s-serverless): deploy ingress (sni_proxy)
9116b79 
base on the examples from:
scylladb/scylla-operator#1076
fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request Nov 8, 2022
@fruch
feature(k8s-serverless): deploy ingress (sni_proxy)
eff3633 
base on the examples from:
scylladb/scylla-operator#1076
fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request Nov 9, 2022
@fruch
feature(k8s-serverless): deploy ingress (sni_proxy)
d1e8dac 
base on the examples from:
scylladb/scylla-operator#1076
vponomaryov added a commit to vponomaryov/scylla-cluster-tests that referenced this pull request Nov 9, 2022
@vponomaryov
feature(k8s): deploy ingress controller
d118528 
To be able to support creation of the 'ingress' objects
we should install 'ingress controller' in our K8S clusters.
So, add this possibility using configuration taken from [1].

To enable it's installation and appropriate configuration
of Scylla clusters just set 'k8s_enable_tls: true' config option.

[1] scylladb/scylla-operator#1076
@vponomaryov vponomaryov mentioned this pull request Nov 9, 2022
Merged
7 tasks
vponomaryov added a commit to vponomaryov/scylla-cluster-tests that referenced this pull request Nov 9, 2022
@vponomaryov
feature(k8s): deploy ingress controller
abef890 
To be able to support creation of the 'ingress' objects
we should install 'ingress controller' in our K8S clusters.
So, add this possibility using configuration taken from [1].

To enable it's installation and appropriate configuration
of Scylla clusters just set 'k8s_enable_tls: true' config option.

[1] scylladb/scylla-operator#1076
vponomaryov added a commit to vponomaryov/scylla-cluster-tests that referenced this pull request Nov 9, 2022
@vponomaryov
feature(k8s): deploy ingress controller
dd45d9a 
To be able to support creation of the 'ingress' objects
we should install 'ingress controller' in our K8S clusters.
So, add this possibility using configuration taken from [1].

To enable it's installation and appropriate configuration
of Scylla clusters just set 'k8s_enable_tls: true' config option.

[1] scylladb/scylla-operator#1076
vponomaryov added a commit to vponomaryov/scylla-cluster-tests that referenced this pull request Nov 9, 2022
@vponomaryov
feature(k8s): deploy ingress controller
c440048 
To be able to support creation of the 'ingress' objects
we should install 'ingress controller' in our K8S clusters.
So, add this possibility using configuration taken from [1].

To enable it's installation and appropriate configuration
of Scylla clusters just set 'k8s_enable_tls: true' config option.

[1] scylladb/scylla-operator#1076
vponomaryov added a commit to vponomaryov/scylla-cluster-tests that referenced this pull request Nov 9, 2022
@vponomaryov
feature(k8s): deploy ingress controller
6bb11d6 
To be able to support creation of the 'ingress' objects
we should install 'ingress controller' in our K8S clusters.
So, add this possibility using configuration taken from [1].

To enable it's installation and appropriate configuration
of Scylla clusters just set 'k8s_enable_tls: true' config option.

[1] scylladb/scylla-operator#1076
fruch added a commit to fruch/scylla-cluster-tests that referenced this pull request Nov 9, 2022
@fruch
feature(k8s-serverless): deploy ingress (sni_proxy)
950db55 
base on the examples from:
scylladb/scylla-operator#1076
vponomaryov added a commit to vponomaryov/scylla-cluster-tests that referenced this pull request Nov 9, 2022
@vponomaryov
feature(k8s): deploy ingress controller
0a73eb4 
To be able to support creation of the 'ingress' objects
we should install 'ingress controller' in our K8S clusters.
So, add this possibility using configuration taken from [1].

To enable it's installation and appropriate configuration
of Scylla clusters just set 'k8s_enable_tls: true' config option.

[1] scylladb/scylla-operator#1076
fruch pushed a commit to scylladb/scylla-cluster-tests that referenced this pull request Nov 9, 2022
@vponomaryov @fruch
feature(k8s): deploy ingress controller
b8e5522 
To be able to support creation of the 'ingress' objects
we should install 'ingress controller' in our K8S clusters.
So, add this possibility using configuration taken from [1].

To enable it's installation and appropriate configuration
of Scylla clusters just set 'k8s_enable_tls: true' config option.

[1] scylladb/scylla-operator#1076
@tnozicka tnozicka removed this from the v1.9 milestone Aug 16, 2023
@zimnx zimnx marked this pull request as draft August 24, 2023 09:38
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2023
@scylla-operator-bot scylla-operator-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2023
@scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 26, 2023
@zimnx zimnx marked this pull request as ready for review September 26, 2023 10:53
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2023
@zimnx
Copy link
Collaborator Author

zimnx commented Sep 26, 2023

overriding stale job
/override ci/prow/e2e-gke

@scylla-operator-bot
Copy link
Contributor

@zimnx: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ci/prow/e2e-gke

Only the following failed contexts/checkruns were expected:

  • ci/prow/build
  • ci/prow/docs
  • ci/prow/e2e-gke-parallel
  • ci/prow/e2e-gke-serial
  • ci/prow/helm-build
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-deps
  • ci/prow/verify-vendorability
  • pull-scylla-operator-build
  • pull-scylla-operator-docs
  • pull-scylla-operator-e2e-gke-parallel
  • pull-scylla-operator-e2e-gke-serial
  • pull-scylla-operator-helm-build
  • pull-scylla-operator-images
  • pull-scylla-operator-unit
  • pull-scylla-operator-verify
  • pull-scylla-operator-verify-deps
  • pull-scylla-operator-verify-vendorability
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

overriding stale job
/override ci/prow/e2e-gke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tnozicka
tnozicka reviewed Sep 27, 2023
View reviewed changes
pkg/cmd/tests/options.go Outdated Show resolved Hide resolved
test/e2e/framework/testcontext.go Outdated Show resolved Hide resolved
test/e2e/set/scyllacluster/scyllacluster_expose.go Outdated Show resolved Hide resolved
test/e2e/set/scyllacluster/scyllacluster_expose.go Outdated Show resolved Hide resolved
test/e2e/set/scyllacluster/scyllacluster_expose.go Outdated Show resolved Hide resolved
test/e2e/set/scyllacluster/scyllacluster_expose.go Outdated Show resolved Hide resolved
test/e2e/utils/helpers.go Show resolved Hide resolved
test/e2e/utils/helpers.go Show resolved Hide resolved
test/e2e/utils/helpers.go Outdated Show resolved Hide resolved
test/e2e/utils/helpers.go Outdated Show resolved Hide resolved
@scylla-operator-bot
Copy link
Contributor

scylla-operator-bot bot commented Sep 28, 2023 •
edited

@zimnx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke 75f6fcb link true /test e2e-gke

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zimnx zimnx requested a review from tnozicka October 2, 2023 09:15
tnozicka
tnozicka reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one open conversation, the rest lgtm - thanks for the updates

@zimnx zimnx requested a review from tnozicka October 3, 2023 10:44
tnozicka
tnozicka reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@scylla-operator-bot scylla-operator-bot bot merged commit 266105e into scylladb:master Oct 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka left review comments

@rzetelskik rzetelskik Awaiting requested review from rzetelskik

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cover connecting via Ingress in E2E tests
2 participants
@zimnx @tnozicka