Bump Kubernetes version to 1.24.9 in CI #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to ensure we also test on the K8S version EKS has. |
zimnx
force-pushed
the
mz/bump-kube-version
branch
24 times, most recently
from
44b0ad2
to
5a39a41
Compare
|
Unless this is critical, let's defer this to future milestones. |
zimnx
changed the title
Our CI uses 1.23.x which will be considered End of Life in 3 months. |
zimnx
force-pushed
the
mz/bump-kube-version
branch
2 times, most recently
from
16747a4
to
639c3db
Compare
zimnx
force-pushed
the
mz/bump-kube-version
branch
2 times, most recently
from
d5de8d7
to
8e76325
Compare
tnozicka
reviewed
Jan 25, 2023
.github/actions/setup-local-volume-provisioner/manifests/50_daemonset.yaml
Outdated
Show resolved
Hide resolved
.github/actions/setup-local-volume-provisioner/manifests/50_daemonset.yaml
Outdated
Show resolved
Hide resolved
tnozicka
reviewed
Jan 25, 2023
zimnx
force-pushed
the
mz/bump-kube-version
branch
from
8e76325
to
1f74b85
Compare
|
@tnozicka Thanks for detailed review, all your comments are addressed. PTAL |
zimnx
force-pushed
the
mz/bump-kube-version
branch
3 times, most recently
from
bf064e4
to
0707324
Compare
tnozicka
reviewed
Jan 26, 2023
| var ( | ||
| registry = initRegistry() | ||
|
|
||
| imageConfigs = initImageConfigs(registry) |
There was a problem hiding this comment.
fwiw, kube has it so the downstreams can customize universal images (like for bash, so they play well with their security, like user ids). I don't think we have the need but I don't feel strong one way or the other
tnozicka
added
the
priority/important-soon
zimnx
force-pushed
the
mz/bump-kube-version
branch
5 times, most recently
from
c0c3847
to
5e83100
Compare
tnozicka
reviewed
Jan 26, 2023
zimnx
force-pushed
the
mz/bump-kube-version
branch
from
5e83100
to
57b442b
Compare
tnozicka
reviewed
Jan 27, 2023
zimnx
force-pushed
the
mz/bump-kube-version
branch
from
57b442b
to
d4c4785
Compare
Currently used minikube with `none` driver requires dockershim coming from 3rd party provider when Kubernetes version above 1.24 is requested. The main reason why we used minikube it's storage provisioner which comes with it. Even though it's not perfect and we have issues with it (scylladb#974). Adding new dependency doesn't seem right for our usecase. This change introduces spawning Kube cluster using dedicated tool `kubeadm`. It gives us more customizable setup, then the previous one, some of the existing hacks are now a configuration option. It also allows us to choose different CRI, in this case I used cri-o. Missing storage provisioner was replaced with battle tested upstream kubernetes-sigs/sig-storage-local-static-provisioner. Fixes scylladb#1137 Fixes scylladb#975
Test logic relied on fact that minikube storage provisioner did not set any NodeAffinity for provisioned PVs. This allowed logic to trigger cleanup logic by adding a NodeAffinity pointing to not existing Node. When proper local volume proviosiner is used, and NodeAffinity is configured for new PVs, test no longer have option to trigger cleanup logic because NodeAffinity field is immutable. To overcome this, the ScyllaCluster is using custom StorageClass not backed by any provisioner running in the cluster. ScyllaCluster is going to request PVC from that StorageClass, and the test is going to request a clone of the original PVC from the default StorageClass to get any storage. Then the bound PV is rebounded to the original PVC but with empty NodeAffinity. This allows the test to trigger the orphaned PV cleanup logic.
zimnx
force-pushed
the
mz/bump-kube-version
branch
from
d4c4785
to
83c37ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently used minikube with
nonedriver requires dockershim comingfrom 3rd party provider when Kubernetes version above 1.24 is requested.
The main reason why we used minikube it's storage provisioner which
comes with it. Even though it's not perfect and we have issues with it (#974).
Adding new dependency doesn't seem right for our usecase.
This change introduces spawning Kube cluster using dedicated tool
kubeadm.It gives us more customizable setup, then the previous one, some of the
existing hacks are now a configuration option.
It also allows us to choose different CRI, in this case I used cri-o.
Missing storage provisioner was replaced with battle tested upstream
kubernetes-sigs/sig-storage-local-static-provisioner.
Fixes #1137
Fixes #975
Requires: