Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generic handlers #1125

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Use generic handlers #1125

merged 1 commit into from
Jan 3, 2023

Conversation

tnozicka
Copy link
Member

Description of your changes:
We have a lot of duplicated code that is growing with every new controller and handler. This PR add generic handlers that allow keeping the logic in one place. This PR is switching the easy 90% we'll switch the leftovers when we have more bandwidth.

Needed by #1111

@tnozicka tnozicka added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 20, 2022
@tnozicka tnozicka added this to the v1.8 milestone Dec 20, 2022
@tnozicka tnozicka changed the title [WIP] Use generic handlers Use generic handlers Dec 22, 2022
@tnozicka tnozicka requested a review from zimnx December 22, 2022 13:34
@zimnx
Copy link
Collaborator

zimnx commented Dec 27, 2022

Suggestions after going through it: tnozicka#18
LGTM when squashed

@tnozicka tnozicka force-pushed the generic-handlers branch 2 times, most recently from 138e216 to 0fa0696 Compare January 2, 2023 12:58
@tnozicka
Copy link
Member Author

tnozicka commented Jan 2, 2023

@zimnx thanks for your fixes!

squashed and rebased

@tnozicka tnozicka mentioned this pull request Jan 2, 2023
Merged
6 tasks
@tnozicka tnozicka modified the milestones: v1.8, v1.9 Jan 2, 2023
zimnx
zimnx previously approved these changes Jan 2, 2023
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@zimnx zimnx enabled auto-merge January 2, 2023 17:48
@tnozicka
Copy link
Member Author

tnozicka commented Jan 3, 2023

(clean rebase)

@zimnx zimnx merged commit 8feced9 into scylladb:master Jan 3, 2023
@tnozicka tnozicka deleted the generic-handlers branch January 3, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tnozicka @zimnx