Fix flakyness of replace node e2e #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnozicka
reviewed
Dec 22, 2022
There was a problem hiding this comment.
would the readiness check @rzetelskik is building help here?
AFAIR it allows for one DN, we have 2 nodes in this e2e, so it wouldn't help. |
Yes, it wouldn't help in this case. After it's been merged you could just increase the number of nodes in this test to 3 though. |
tnozicka
added
the
priority/important-soon
tnozicka
reviewed
Jan 2, 2023
zimnx
force-pushed
the
mz/fix-replace-node-flake
branch
from
7ffac2c
to
3e8f6d9
Compare
zimnx
added
kind/flake
Full quorum check is sensitive to seeing nodes not being part of the cluster, when such node is spotted it immediately returns an error. In replace node e2e, it could happen that cluster become ready before replaced node was acknowledged by the others. In this case, full quorum check returned an error, because it saw a IP not bound to any cluster Service. To fix it, test waits until cluster is rolled out, and replaced node is seen by the other one, before the full quorum check is validated.
zimnx
force-pushed
the
mz/fix-replace-node-flake
branch
from
3e8f6d9
to
dfea5a7
Compare
tnozicka
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full quorum check is sensitive to seeing nodes not being part of the cluster, when such node is spotted it immediately returns an error.
In replace node e2e, it could happen that cluster become ready before replaced node was acknowledged by the others.
In this case, full quorum check returned an error, because it saw a IP not bound to any cluster Service.
To fix it, test waits until cluster is rolled out, and replaced node is seen by the other one, before the full quorum check is validated.