Wait for haproxy-ingress to be ready when setting up the example #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnozicka
added
priority/important-soon
zimnx
previously approved these changes
Feb 28, 2023
tnozicka
force-pushed
the
fix-haproxy-wait
branch
from
eeeb806
to
93e130b
Compare
zimnx
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Without a readiness probe the haproxy deployment will go immediately ready which will unblock the corresponding
rollout statusbut if it never starts up properly the liveness will kill it. At least reusing the liveness endpoint for readyness fixes the issue. (There is no dedicated/readyz:( )Which issue is resolved by this Pull Request:
Flakes and bugs the manifested as failures for tests that use ingresses.