Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PrometheusExposeOptions struct name in API definitions #1198

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

tnozicka
Copy link
Member

@tnozicka tnozicka commented Apr 3, 2023

Description of your changes:
This fixes the wrong struct used in scylladbmonitoring.spec.components.prometheus.exposeOptions. Fortunately, at this point the structs are equivalent from the API perspective and we can switch them.

@tnozicka tnozicka added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Apr 3, 2023
@tnozicka tnozicka added this to the v1.9 milestone Apr 3, 2023
rzetelskik
rzetelskik previously approved these changes Apr 4, 2023
@tnozicka tnozicka requested a review from zimnx April 4, 2023 10:29
@zimnx zimnx enabled auto-merge April 4, 2023 10:59
@zimnx zimnx merged commit 0910f20 into scylladb:master Apr 4, 2023
17 checks passed
@tnozicka tnozicka deleted the fix-monitoring-api branch April 4, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants