Extend test runner with a report verifier checking if every Spec was ran exactly once #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzetelskik
force-pushed
the
test-runner-verify-report
branch
3 times, most recently
from
41e9b3e
to
423de97
Compare
rzetelskik
changed the title
rzetelskik
added
kind/bug
rzetelskik
removed
the
kind/machinery
rzetelskik
force-pushed
the
test-runner-verify-report
branch
from
423de97
to
fd6a37b
Compare
|
@tnozicka please let me know if the hardcoded list of expected specs is acceptable for a temporary mitigation or if it should be gathered in a CI action |
tnozicka
force-pushed
the
test-runner-verify-report
branch
from
fd6a37b
to
4dfd435
Compare
tnozicka
reviewed
May 18, 2023
tnozicka
added
the
priority/critical-urgent
zimnx
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes: Recently we've hit #1245 which managed to bork master. The issue is most likely caused by #1176. Until the root cause is fixed, this PR mitigates it by checking the generated report and verifying that all specs were assigned to exactly one parallel process.
Mitigates #1176 temporarily to unbork the CI.