-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance handling of non-integer values around replica checks in Operator Helm Chart #1257
Conversation
This commit improves the replica checks in the operator.pdb.yaml and webhookserver.pdb.yaml templates. The conditions have been modified to handle non-integer values, enabling compatibility with commands such as 'helm install --set ...'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akukhar, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test all |
@akukhar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
1e4839e
into
scylladb:master
Description of your changes:
This PR improves the replica checks in the operator.pdb.yaml and webhookserver.pdb.yaml templates. The conditions have been modified to handle non-integer values, enabling compatibility with commands such as 'helm install --set ...'.
Which issue is resolved by this Pull Request:
No GH issue has been opened so far.
PR improves compatibility with helm CLI and indirectly with set {} blocks of Terraform's helm provider.
Here is how to reproduce the problem: