Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance handling of non-integer values around replica checks in Operator Helm Chart #1257

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

akukhar
Copy link

@akukhar akukhar commented May 20, 2023

Description of your changes:

This PR improves the replica checks in the operator.pdb.yaml and webhookserver.pdb.yaml templates. The conditions have been modified to handle non-integer values, enabling compatibility with commands such as 'helm install --set ...'.

Which issue is resolved by this Pull Request:
No GH issue has been opened so far.

PR improves compatibility with helm CLI and indirectly with set {} blocks of Terraform's helm provider.

Here is how to reproduce the problem:

$ helm -n scylla-operator install --set replicas=3 scylla-operator .
Error: INSTALLATION FAILED: template: scylla-operator/templates/operator.pdb.yaml:1:7: executing "scylla-operator/templates/operator.pdb.yaml" at <gt .Values.replicas 1.0>: error calling gt: incompatible types for comparison
$

@zimnx zimnx changed the title Enhance handling of non-integer values in replica checks Enhance handling of non-integer values in Operator Helm Chart replica checks May 22, 2023
@zimnx zimnx added this to the v1.9 milestone May 22, 2023
@zimnx zimnx added the kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. label May 22, 2023
@zimnx zimnx changed the title Enhance handling of non-integer values in Operator Helm Chart replica checks Enhance handling of non-integer values around replica checks in Operator Helm Chart May 22, 2023
This commit improves the replica checks in the operator.pdb.yaml and webhookserver.pdb.yaml templates. The conditions have been modified to handle non-integer values, enabling compatibility with commands such as 'helm install --set ...'.
@tnozicka tnozicka removed this from the v1.9 milestone Aug 16, 2023
@tnozicka tnozicka requested a review from zimnx August 17, 2023 14:57
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akukhar, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 18, 2023
@zimnx zimnx added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Aug 18, 2023
@tnozicka
Copy link
Member

/retest

@tnozicka
Copy link
Member

/test all

@scylla-operator-bot
Copy link
Contributor

scylla-operator-bot bot commented Aug 23, 2023

@akukhar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke 1776463 link true /test e2e-gke

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@scylla-operator-bot scylla-operator-bot bot merged commit 1e4839e into scylladb:master Aug 24, 2023
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants