Fix panic in Operator occuring during node replacement #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log messages and progressing condition were using nil Pod object which caused panic due to nil pointer dereference. Fixes scylladb#1287
rzetelskik
reviewed
Jun 26, 2023
| @@ -360,13 +360,13 @@ func (scc *Controller) syncServices( | |||
|
|
|||
| klog.V(2).InfoS("Pod has not been recreated by the StatefulSet controller yet", | |||
| "ScyllaCluster", klog.KObj(sc), | |||
| "Pod", klog.KObj(pod), | |||
| "Pod", klog.KObj(svc), | |||
There was a problem hiding this comment.
I think klog.ObjectRef{Namespace: svc.Namespace, Name: svc.Name} would be more fitting
Edit: klog.KRef(svc.Namespace, svc.Name)
There was a problem hiding this comment.
why would be more fitting? KObj is essentially doing that.
There was a problem hiding this comment.
It's more explicit. Imo "Pod", klog.KObj(svc) looks unintentional and if I ever saw that without any comment, I'd probably think it's a mistake. I'm not insisting though, just a nit.
rzetelskik
approved these changes
Jun 26, 2023
|
Do you plan to backport it to 1.9? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log messages and progressing condition were using nil Pod object which caused panic due to nil pointer dereference.
Fixes #1287