Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enhancement proposal for controlling external seeds #1306

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Add enhancement proposal for controlling external seeds #1306

merged 1 commit into from
Aug 23, 2023

Conversation

rzetelskik
Copy link
Member

Description of your changes:
Currently, ScyllaDB Operator does not provide any support, neither automated, nor manual, for controlling external seeds propagated to ScyllaDB cluster nodes.
Controlling the provision of external seeds is a prerequisite for supporting both manual and automated setup of multi datacenter ScyllaDB clusters, a feature long requested by many of its users, and as such is a vital step on our roadmap.

This PR proposes an extension to the existing ScyllaCluster API and corresponding changes to the ScyllaDB operator and sidecar.

Which issue is resolved by this Pull Request:
Resolves #1304

@rzetelskik rzetelskik added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/documentation Categorizes issue or PR as related to documentation. labels Jul 31, 2023
@rzetelskik rzetelskik added this to the v1.10 milestone Jul 31, 2023
@rzetelskik rzetelskik force-pushed the external-seeds-proposal branch 2 times, most recently from 9522d50 to 6940d85 Compare August 1, 2023 10:32
zimnx
zimnx reviewed Aug 2, 2023
View reviewed changes
enhancements/proposals/external_seeds.md Outdated Show resolved Hide resolved
enhancements/proposals/external_seeds.md Outdated Show resolved Hide resolved
enhancements/proposals/external_seeds.md Outdated Show resolved Hide resolved
enhancements/proposals/external_seeds.md Outdated Show resolved Hide resolved
enhancements/proposals/external_seeds.md Outdated Show resolved Hide resolved
enhancements/proposals/external_seeds.md Outdated Show resolved Hide resolved
@rzetelskik rzetelskik marked this pull request as draft August 2, 2023 13:16
@rzetelskik rzetelskik marked this pull request as ready for review August 3, 2023 10:30
@rzetelskik rzetelskik requested a review from zimnx August 3, 2023 10:32
@rzetelskik rzetelskik force-pushed the external-seeds-proposal branch 2 times, most recently from 9a108d2 to 40203b8 Compare August 8, 2023 12:28
@scylla-operator-bot scylla-operator-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 8, 2023
zimnx
zimnx previously approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

enhancements/proposals/1304-external-seeds/README.md Outdated Show resolved Hide resolved
@rzetelskik rzetelskik mentioned this pull request Aug 11, 2023
Merged
1 task
@rzetelskik rzetelskik force-pushed the external-seeds-proposal branch 2 times, most recently from 6739bde to b05fd7a Compare August 11, 2023 07:41
tnozicka
tnozicka reviewed Aug 15, 2023
View reviewed changes
enhancements/proposals/1304-external-seeds/README.md Outdated Show resolved Hide resolved
enhancements/proposals/1304-external-seeds/README.md Outdated Show resolved Hide resolved
enhancements/proposals/1304-external-seeds/README.md Outdated Show resolved Hide resolved
enhancements/proposals/1304-external-seeds/README.md Outdated Show resolved Hide resolved
enhancements/proposals/1304-external-seeds/README.md Show resolved Hide resolved
enhancements/proposals/1304-external-seeds/README.md Outdated Show resolved Hide resolved
enhancements/proposals/1304-external-seeds/README.md Show resolved Hide resolved
enhancements/proposals/1304-external-seeds/README.md Outdated Show resolved Hide resolved
enhancements/proposals/1304-external-seeds/README.md Outdated Show resolved Hide resolved
@rzetelskik rzetelskik force-pushed the external-seeds-proposal branch 4 times, most recently from a176593 to ef25174 Compare August 17, 2023 11:17
@rzetelskik rzetelskik removed this from the v1.10 milestone Aug 17, 2023
@rzetelskik rzetelskik added this to the v1.11 milestone Aug 23, 2023
@rzetelskik
Copy link
Member Author

/retest

@tnozicka
Copy link
Member

/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2023
@scylla-operator-bot
Copy link
Contributor

scylla-operator-bot bot commented Aug 23, 2023 •
edited

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke 17574f8 link true /test e2e-gke

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tnozicka
Copy link
Member

docs only, the e2e jobs are not triggered any more on these (but they have been triggered here before)
/override e2e-gke-serial
/override e2e-gke-parallel
/override e2e-gke

@scylla-operator-bot
Copy link
Contributor

@tnozicka: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-gke
  • e2e-gke-parallel
  • e2e-gke-serial

Only the following failed contexts/checkruns were expected:

  • All tests successfull
  • Failure notifications
  • Promote artifacts
  • Test e2e parallel (with alpha features)
  • Verify PR milestone
  • ci/prow/build
  • ci/prow/docs
  • ci/prow/e2e-gke
  • ci/prow/e2e-gke-parallel
  • ci/prow/e2e-gke-serial
  • ci/prow/helm-build
  • ci/prow/images
  • ci/prow/verify
  • ci/prow/verify-deps
  • ci/prow/verify-vendorability
  • pull-scylla-operator-build
  • pull-scylla-operator-docs
  • pull-scylla-operator-e2e-gke-parallel
  • pull-scylla-operator-e2e-gke-serial
  • pull-scylla-operator-helm-build
  • pull-scylla-operator-images
  • pull-scylla-operator-verify
  • pull-scylla-operator-verify-deps
  • pull-scylla-operator-verify-vendorability
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

docs only, the e2e jobs are not triggered any more on these (but they have been triggered here before)
/override e2e-gke-serial
/override e2e-gke-parallel
/override e2e-gke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka
Copy link
Member

/override ci/prow/e2e-gke-serial
/override ci/prow/e2e-gke-parallel
/override ci/prow/e2e-gke

@scylla-operator-bot
Copy link
Contributor

@tnozicka: Overrode contexts on behalf of tnozicka: ci/prow/e2e-gke, ci/prow/e2e-gke-parallel, ci/prow/e2e-gke-serial

In response to this:

/override ci/prow/e2e-gke-serial
/override ci/prow/e2e-gke-parallel
/override ci/prow/e2e-gke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot merged commit 6ff7fa8 into scylladb:master Aug 23, 2023
26 of 28 checks passed
@rzetelskik rzetelskik deleted the external-seeds-proposal branch August 23, 2023 13:35
@rzetelskik rzetelskik added kind/design Categorizes issue or PR as related to design. and removed kind/documentation Categorizes issue or PR as related to documentation. labels Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx left review comments

@tnozicka tnozicka Awaiting requested review from tnozicka

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

Create enhancmet proposal for controlling external seeds on ScyllaClusters
3 participants
@rzetelskik @tnozicka @zimnx