Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create missing mount points when tuning nodes #1335

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

tnozicka
Copy link
Member

Description of your changes:
On GKE the nodetuning was failing because of a missing mount. X-mount.mkdir makes sure it's always there.

@tnozicka tnozicka added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 18, 2023
@scylla-operator-bot scylla-operator-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 18, 2023
@tnozicka tnozicka added this to the v1.11 milestone Aug 18, 2023
@scylla-operator-bot
Copy link
Contributor

@tnozicka: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke 279c4d7 link true /test e2e-gke

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tnozicka
Copy link
Member Author

https://github.com/scylladb/scylla-operator/actions/runs/5899796911/job/16003016773#step:3:3042

Summarizing 1 Failure:
  [FAIL] ScyllaCluster should replace a node [It] using HostID based procedure when version of ScyllaDB is "docker.io/scylladb/scylla:5.2.0"
  github.com/scylladb/scylla-operator/test/e2e/set/scyllacluster/verify.go:277

Ran 22 of 30 Specs in 2598.992 seconds
FAIL! -- 21 Passed | 1 Failed | 1 Pending | 7 Skipped

e2e-parallel fails the same way on master
https://github.com/scylladb/scylla-operator/actions/runs/5896785627/job/15995395176#step:3:4504

e2e-parallel with alpha fails the same way plus monitoring flake

Summarizing 2 Failures:
  [FAIL] ScyllaDBMonitoring [It] should setup monitoring stack
  github.com/scylladb/scylla-operator/test/e2e/set/scylladbmonitoring/scylladbmonitoring.go:180
  [FAIL] ScyllaCluster should replace a node [It] using HostID based procedure when version of ScyllaDB is "docker.io/scylladb/scylla:5.2.0"
  github.com/scylladb/scylla-operator/test/e2e/set/scyllacluster/verify.go:277

Ran 24 of 30 Specs in 2491.639 seconds
FAIL! -- 22 Passed | 2 Failed | 1 Pending | 5 Skipped

none of them seem connected to the change done here

Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2023
@tnozicka tnozicka merged commit 2cf1627 into scylladb:master Aug 18, 2023
31 of 39 checks passed
@tnozicka tnozicka deleted the fix-mounts branch August 18, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants