Add enhancement proposal for exposing ScyllaCluster #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scylla-operator-bot
bot
added
approved
zimnx
changed the title
tnozicka
reviewed
Aug 29, 2023
zimnx
force-pushed
the
mz/expose-scylla-outside-proposal
branch
from
88bc79d
to
478756f
Compare
|
Marked all my comments as resolved, only left the ones which @tnozicka followed up on for him to resolve. Assume lgtm from me once they are resolved. |
The proposed change aims to improve the accessibility of ScyllaDB nodes by modifying the way they are exposed. By implementing a switch to specify the type of IP addresses to use, such as Pod IPs or LoadBalancer services, it would allow reaching the nodes from external clients or other data centers.
zimnx
force-pushed
the
mz/expose-scylla-outside-proposal
branch
from
478756f
to
62d77a6
Compare
tnozicka
approved these changes
Sep 6, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
The proposed change aims to improve the accessibility of ScyllaDB nodes by modifying the way they are exposed. By
implementing a switch to specify the type of IP addresses to use, such as Pod IPs or LoadBalancer services, it would
allow reaching the nodes from external clients or other data centers.
Which issue is resolved by this Pull Request:
Resolves #1277