Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #1363

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Update dependencies #1363

merged 2 commits into from
Sep 1, 2023

Conversation

tnozicka
Copy link
Member

@tnozicka tnozicka commented Sep 1, 2023 •
edited

Description of your changes:
This PR updates our dependencies to the latest stable levels.

@tnozicka tnozicka added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Sep 1, 2023
@scylla-operator-bot scylla-operator-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 1, 2023
@scylla-operator-bot scylla-operator-bot bot added the area/dependency Issues or PRs related to dependency changes label Sep 1, 2023
@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
zimnx
zimnx reviewed Sep 1, 2023
View reviewed changes
pkg/leaderelection/leaderelection.go Outdated
@@ -39,7 +39,7 @@ func Run(ctx context.Context, programName, lockName, lockNamespace string, clien

// TODO: Migrate to single lock using just coordination API in >=1.9.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thx

zimnx
zimnx reviewed Sep 1, 2023
View reviewed changes
go.mod Outdated
sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect
sigs.k8s.io/structured-merge-diff/v4 v4.3.0 // indirect
)

replace github.com/gocql/gocql => github.com/scylladb/gocql v1.7.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's new version of scylladb/gocql which could be bumped too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thx

zimnx
zimnx reviewed Sep 1, 2023
View reviewed changes
vendor/dario.cat/mergo/CODE_OF_CONDUCT.md
@@ -0,0 +1,46 @@
# Contributor Covenant Code of Conduct
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should belong to Update autogenerated commit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update dependencies encompasses go.mod, go.sum and vendor/ so it seems placed correctly

@tnozicka tnozicka force-pushed the bump-deps branch 2 times, most recently from 742c33e to 089a23b Compare September 1, 2023 10:19
zimnx
zimnx reviewed Sep 1, 2023
View reviewed changes
pkg/leaderelection/leaderelection.go Outdated
lock, err := resourcelock.New(
resourcelock.ConfigMapsLeasesResourceLock,
resourcelock.LeasesResourceLock,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be visible in release notes, please extract it to separate PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1364

@tnozicka
Copy link
Member Author

tnozicka commented Sep 1, 2023

/retest

@zimnx
Copy link
Collaborator

zimnx commented Sep 1, 2023

/lgtm
/approve

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2023
@scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit 4625fdc into scylladb:master Sep 1, 2023
10 checks passed
@tnozicka tnozicka deleted the bump-deps branch September 1, 2023 14:36
@rzetelskik rzetelskik mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx left review comments

@rzetelskik rzetelskik Awaiting requested review from rzetelskik

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tnozicka @zimnx