-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip systemd dependent unit test when systemd is not available #1369
Skip systemd dependent unit test when systemd is not available #1369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
I don't know, this feels out of place. Conditional unit tests not executed in the CI seem weird and probably the place where it breaks at some point.
If a unit test needs system wide installation of another component it may not be a good unit test.
AFAIK, systemd runs fine inside containers we just don't start it, neither I am sure whether we should but it's an option.
hm, I don't see a quick way out of it and we need to get our unit suite working. I've filled #1379 but let's not take the conditional unit as a precedence. Please reference the issue in the code change. /hold cancel |
when unit test is run inside a container where systemd is not available the test is failing. It works fine when test binary is ran directly on the host, and with NodeConfig because NC DaemonSet chroots into host where systemd is present.
7003200
to
b7b54fc
Compare
Added reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Test started failing due to bug in scylladb#1369. This time it passes on systemd-enabled systems, and within container where it's not available.
Test started failing due to bug in scylladb#1369. This time it passes on systemd-enabled systems, and within container where it's not available.
Test started failing due to bug in scylladb#1369. This time it passes on systemd-enabled systems, and within container where it's not available.
when unit test is run inside a container where systemd is not
available the test is failing. It works fine when test binary is ran directly on the host,
and with NodeConfig because NC DaemonSet chroots into host where systemd is present.