Fix waiting for waitGroup in ScyllaCluster Orphaned PV e2e test #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzetelskik
added
kind/bug
scylla-operator-bot
bot
added
the
size/S
zimnx
reviewed
Sep 11, 2023
rzetelskik
force-pushed
the
orphaned-pv-fix
branch
2 times, most recently
from
f3bf8ae
to
d462eb6
Compare
scylla-operator-bot
bot
added
size/XS
scylla-operator-bot
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
scylla-operator-bot
bot
added
the
approved
rzetelskik
force-pushed
the
orphaned-pv-fix
branch
from
d462eb6
to
e10e114
Compare
scylla-operator-bot
bot
removed
the
lgtm
|
/lgtm |
scylla-operator-bot
bot
added
the
lgtm
|
PR description is stale, please update it. |
|
/test e2e-gke-serial |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Currently, when an error occurs in
ScyllaCluster Orphaned PV controller [It] should replace a node with orphaned PVE2E test, the test hangs indefinitely, waiting for waitGroup, because of the order of deferred functions. This PR fixes it by reordering the deferred functions.Which issue is resolved by this Pull Request:
Resolves #1390