Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about system_auth RF configuration to the documentation #1419

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Sep 25, 2023

Description of your changes: As per https://opensource.docs.scylladb.com/stable/operating-scylla/procedures/cluster-management/add-node-to-cluster.html, users having ScyllaDB configured with authenticator set to PasswordAuthenticator, need to manually set system_auth's RF after every topology change. This PR adds a note mentioning that to our docs. It also merges scale out / scale down parts of the doc to avoid repetition.

Which issue is resolved by this Pull Request:
Resolves #1358

@rzetelskik rzetelskik added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/documentation Categorizes issue or PR as related to documentation. labels Sep 25, 2023
@rzetelskik rzetelskik added this to the v1.11 milestone Sep 25, 2023
@scylla-operator-bot scylla-operator-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 25, 2023
@tnozicka
Copy link
Member

/hold
(for #1418)

@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2023
docs/source/generic.md Outdated Show resolved Hide resolved
docs/source/generic.md Outdated Show resolved Hide resolved
docs/source/generic.md Outdated Show resolved Hide resolved
docs/source/generic.md Outdated Show resolved Hide resolved
Copy link

@annastuchlik annastuchlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good; I've left minor comments.
I can't check how it renders until #1418 is merged.

@rzetelskik rzetelskik changed the title Add note about system_auth RF configuration to scaling docs Add notes about system_auth RF configuration to the documentation Sep 25, 2023
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

docs/source/generic.md Outdated Show resolved Hide resolved
@scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2023
@scylla-operator-bot scylla-operator-bot bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@rzetelskik
Copy link
Member Author

I changed the MyST syntax back to recommonmark to decouple from #1418.
/hold cancel

@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2023
@tnozicka
Copy link
Member

tnozicka commented Oct 3, 2023

/lgtm

/hold cancel
(no longer needs #1418)

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@scylla-operator-bot scylla-operator-bot bot merged commit 463427d into scylladb:master Oct 3, 2023
8 checks passed
@rzetelskik rzetelskik deleted the system_auth_docs branch October 3, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

system_auth table RF is not extended during scale out?
4 participants