Add documentation about new ScyllaCluster's exposing options #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimnx
added
the
kind/documentation
scylla-operator-bot
bot
added
approved
zimnx
force-pushed
the
mz/expose-docs
branch
from
f48af50
to
dde98e1
Compare
|
/hold |
scylla-operator-bot
bot
added
the
do-not-merge/hold
|
/cc @annastuchlik |
tnozicka
reviewed
Oct 2, 2023
rzetelskik
reviewed
Oct 2, 2023
zimnx
force-pushed
the
mz/expose-docs
branch
2 times, most recently
from
4b325f2
to
1dc4eb3
Compare
|
/hold cancel |
scylla-operator-bot
bot
removed
the
do-not-merge/hold
rzetelskik
reviewed
Oct 3, 2023
|
@zimnx thanks for the updates, I resolved most comments and left a few new ones |
zimnx
force-pushed
the
mz/expose-docs
branch
3 times, most recently
from
8fe1a88
to
20491e3
Compare
|
/approve |
Documentation covers meaning and configuration options of new fields in `exposeOptions`. Selected examples explains how clients and nodes interconnect ScyllaCluster nodes.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation covers meaning and configuration options of new fields in
exposeOptionsadded in #1359.Selected examples explains how clients and nodes interconnect ScyllaCluster nodes.
Fixes #1380