Remove explicit copying of replace label between Service instances #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scylla-operator-bot
bot
added
the
size/S
scylla-operator-bot
bot
added
the
approved
|
/retest |
rzetelskik
force-pushed
the
replace-remove-explicit-label-copy
branch
from
21ba9bd
to
d5da342
Compare
scylla-operator-bot
bot
added
size/M
rzetelskik
force-pushed
the
replace-remove-explicit-label-copy
branch
from
d5da342
to
8f53bc8
Compare
scylla-operator-bot
bot
added
size/S
|
@zimnx the change required some adjustment to unit tests, please check whether the changes to the current behaviour are acceptable. I believe |
rzetelskik
force-pushed
the
replace-remove-explicit-label-copy
branch
2 times, most recently
from
b8a84f9
to
dbfde25
Compare
scylla-operator-bot
bot
added
the
do-not-merge/work-in-progress
rzetelskik
force-pushed
the
replace-remove-explicit-label-copy
branch
from
dbfde25
to
1215393
Compare
scylla-operator-bot
bot
added
size/M
scylla-operator-bot
bot
removed
the
do-not-merge/work-in-progress
rzetelskik
force-pushed
the
replace-remove-explicit-label-copy
branch
from
1215393
to
aa89840
Compare
…eplacement procedure
rzetelskik
force-pushed
the
replace-remove-explicit-label-copy
branch
from
6659ff5
to
3a37529
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes: Currently the replace label is copied explicitly between Service instances. This can result in the replace label being carried over past the end of the replacement procedure in case the replace label is not removed from the original Service on time, which can in turn break the node, as observed in #1240. This PR removes the superfluous explicit copy of the replacement label. It's necessary in neither the old nor the new replacement procedure. In the old procedure, the label will be picked up from ScyllaCluster status, while the new procedure doesn't terminate services. This change should fix the issue for the new replacement procedure, as the replacement label will never be carried over to a new Service instance. Unfortunately, this PR doesn't fix the deprecated procedure.
Which issue is resolved by this Pull Request:
Resolves #1240