Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly disable CQL over TLS in Scylla Manager cluster integration #1798

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Explicitly disable CQL over TLS in Scylla Manager cluster integration #1798

merged 1 commit into from
Mar 11, 2024

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Mar 7, 2024 •
edited

Description of your changes: This PR disables CQL over TLS in Scylla Manager cluster integration. See #1674.

Requires #1797

Which issue is resolved by this Pull Request:
Resolves #1674

/hold for #1797
/kind bug
/priority critical-urgent
/cc

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes: WIP

Which issue is resolved by this Pull Request:
Resolves #

/hold for #1797
/kind bug
/priority critical-urgent
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. area/dependency Issues or PRs related to dependency changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2024
tnozicka
tnozicka reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

pkg/controller/manager/sync_action.go Show resolved Hide resolved
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 7, 2024
@tnozicka
Copy link
Member

tnozicka commented Mar 7, 2024

please backport this to v1.12 when it lands

@scylla-operator-bot scylla-operator-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2024
@scylla-operator-bot scylla-operator-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2024
@rzetelskik rzetelskik mentioned this pull request Mar 8, 2024
Closed
@rzetelskik rzetelskik changed the title [WIP] Explicitly disable CQL over TLS in Scylla Manager cluster integration Explicitly disable CQL over TLS in Scylla Manager cluster integration Mar 8, 2024
@scylla-operator-bot scylla-operator-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 8, 2024
@rzetelskik rzetelskik requested a review from zimnx March 8, 2024 10:24
@rzetelskik rzetelskik removed the area/dependency Issues or PRs related to dependency changes label Mar 8, 2024
zimnx
zimnx approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign tnozicka

@rzetelskik
Copy link
Member Author

/hold cancel

@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2024
@rzetelskik rzetelskik mentioned this pull request Mar 8, 2024
Merged
tnozicka
tnozicka approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
thanks

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit 8d95973 into scylladb:master Mar 11, 2024
12 checks passed
@rzetelskik rzetelskik deleted the manager-disable-tls branch March 11, 2024 08:01
@rzetelskik rzetelskik mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@tnozicka tnozicka tnozicka approved these changes

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explicitly disable CQL over TLS (that never worked but breaks backups)
3 participants
@rzetelskik @tnozicka @zimnx