Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sphinx-scylladb-theme to 1.7.1 #1895

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Apr 15, 2024

Description of your changes: Update sphinx-scylladb-theme docs dependency to 1.7.1. Most notably, it adds scylladb/sphinx-scylladb-theme#1051.

Which issue is resolved by this Pull Request:
Resolves #1893

/kind machinery
/priority important-soon

Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 15, 2024
@rzetelskik
Copy link
Member Author

rzetelskik commented Apr 15, 2024

/kind machinery
/priority important-soon

@scylla-operator-bot scylla-operator-bot bot added kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 15, 2024
@rzetelskik rzetelskik marked this pull request as ready for review April 15, 2024 16:37
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2024
@rzetelskik rzetelskik added kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. and removed kind/documentation Categorizes issue or PR as related to documentation. labels Apr 15, 2024
docs/pyproject.toml Outdated Show resolved Hide resolved
@tnozicka
Copy link
Member

hm, the menu is gone
/hold

Screenshot from 2024-04-16 12-00-05

@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2024
@rzetelskik
Copy link
Member Author

rzetelskik commented Apr 16, 2024

@tnozicka works for me, including the auto scroll
image

$ podman run -it --pull=Always --rm -v="$( pwd )/docs:/go/$( go list -m )/docs:Z" --workdir="/go/$( go list -m )/docs" -p 5500:5500 quay.io/scylladb/scylla-operator-images:poetry-1.5 bash -euExo pipefail -O inherit_errexit -c 'make setup dirhtml multiversionpreview'

@tnozicka
Copy link
Member

tnozicka commented Apr 16, 2024

I run poetry install && make preview inside the container. That used to work before, I can try this on a clean system if you confirm it works for you but there can be something hidden related to the upgrade.

@tnozicka
Copy link
Member

tnozicka commented Apr 16, 2024

make setup dirhtml multiversionpreview

btw. those are run in parallel / racy (modulo explicit deps order) depending on other things but the order is generally not guaranteed

@rzetelskik
Copy link
Member Author

podman run -it --pull=Always --rm -v="$( pwd )/docs:/go/$( go list -m )/docs:Z" --workdir="/go/$( go list -m )/docs" -p 5500:5500 quay.io/scylladb/scylla-operator-images:poetry-1.5 bash -euExo pipefail -O inherit_errexit -c 'poetry install && make preview'

This also works fine for me.

image

Did you clean the build dir before running it?

@tnozicka
Copy link
Member

never had to but it helped
/shrug

/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Apr 17, 2024
@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@rzetelskik
Copy link
Member Author

@tnozicka can we cancel the hold then?

@tnozicka
Copy link
Member

/hold cancel

@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit f604695 into scylladb:master Apr 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to use latest sphinx-scylladb-theme
2 participants