Remove seed node label #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tnozicka should we also get rid of Replacing a dead seed node section from the operator docs? |
rzetelskik
added
the
kind/cleanup
Yes, additional steps are no longer needed. Actually this could be a separate PR which should be backported to 1.4: #726 |
zimnx
reviewed
Jul 27, 2021
| // as the label is still used by v1.3 sidecar before the new cluster version rolls out. | ||
| // If Member is seed, add the appropriate label | ||
| if strings.HasSuffix(name, "-0") || strings.HasSuffix(name, "-1") { | ||
| labels[naming.SeedLabel] = "" |
There was a problem hiding this comment.
Please also remove definition and other usages.
rzetelskik
force-pushed
the
remove-seed-node-label
branch
from
7c1cb92
to
cd7113e
Compare
|
Opened #727 |
rzetelskik
force-pushed
the
remove-seed-node-label
branch
from
cd7113e
to
62c2496
Compare
rzetelskik
force-pushed
the
remove-seed-node-label
branch
2 times, most recently
from
a79ef90
to
b8679d6
Compare
rzetelskik
force-pushed
the
remove-seed-node-label
branch
from
b8679d6
to
2b78b01
Compare
zimnx
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #704