Run PREPARE on all nodes (Issue #106) #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psarna
reviewed
Nov 23, 2020
scylla/src/transport/session.rs
Outdated
| let mut results = try_join_all(handles).await?; | ||
|
|
||
| // Check if every received statement has the same ID | ||
| for p in results.windows(2) { |
There was a problem hiding this comment.
Please move this additional check to a separate helper function (called validate_prepare_ids or something alike).
Also, consider writing it in a more declarative fashion, e.g.:
results.windows(2).all(|p| p[0].get_id() == p[1].get_id()) // + add error handling at the end of the chain
piodul
reviewed
Nov 23, 2020
scylla/src/transport/session.rs
Outdated
| )), | ||
| _ => Err(anyhow!("Unexpected frame received")), | ||
| let connections = self.get_connections()?; | ||
| let all_connections = connections.iter().map(|(_, v)| v).flatten(); |
There was a problem hiding this comment.
Use flat_map:
let all_connections = connections.iter().flat_map(|(_, v)| v);
|
@havaker There were two big PRs merged which caused this PR to have conflicts with the main branch - please rebase. |
havaker
force-pushed
the
prepare-all-nodes
branch
from
828c206
to
ebdacee
Compare
Done |
piodul
reviewed
Dec 4, 2020
scylla/src/transport/session.rs
Outdated
Comment on lines
197
to
200
| match results.pop() { | ||
| Some(result) => Ok(result), | ||
| None => Err(TransportError::NoConnectionsAvailable), | ||
| } |
There was a problem hiding this comment.
Convert it to:
results.pop().ok_or_else(TransportError::NoConnectionsAvailable)There was a problem hiding this comment.
Done (I chose to use ok_or instead of ok_or_else)
havaker
force-pushed
the
prepare-all-nodes
branch
from
ebdacee
to
c104d16
Compare
psarna
approved these changes
Dec 4, 2020
piodul
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements #106 by sending PREPARE via all available connections.