Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scylla-cql: Use #[cfg(feature = "time")] for time related impl SerializeCql's #898

Merged
merged 2 commits into from Jan 3, 2024
Merged

scylla-cql: Use #[cfg(feature = "time")] for time related impl SerializeCql's #898

merged 2 commits into from Jan 3, 2024

Conversation

oeb25
Copy link
Contributor

@oeb25 oeb25 commented Dec 28, 2023 •
edited

Fixes: #897, see the issue for details.

Additionally I went ahead and checked that --no-default-features -F time also works.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@oeb25 oeb25 mentioned this pull request Dec 28, 2023
Closed
piodul
piodul reviewed Dec 30, 2023
View reviewed changes
Copy link
Collaborator

@piodul piodul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

When I reviewed the changes which introduced the time and chrono features, I was a bit too optimistic and thought that only checking compilation with and without all features would suffice. Would you mind adding some steps to .github/workflows.yml to check that everything compiles when only one of the time, chrono, secret features is enabled? You could base them on the existing Cargo check with all serialization features step.

@oeb25
Copy link
Contributor Author

oeb25 commented Dec 31, 2023

Good idea! I've added three steps to the job, and it seems to work.

As a complete side note, I've found that - uses: Swatinem/rust-cache@v2 can speed-up CI quite a bit! So if that's something that you are interested in I can open up a PR to measure the difference?

Lorak-mmk
Lorak-mmk reviewed Jan 2, 2024
View reviewed changes
.github/workflows/rust.yml Outdated
Comment on lines 37 to 41
- name: Cargo check with all secret feature
run: cargo check --all-targets --manifest-path "scylla/Cargo.toml" --features "secret"
- name: Cargo check with all chrono feature
run: cargo check --all-targets --manifest-path "scylla/Cargo.toml" --features "chrono"
- name: Cargo check with all time feature
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove "all" words from descriptions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops!

@Lorak-mmk
Copy link
Collaborator

Good idea! I've added three steps to the job, and it seems to work.

As a complete side note, I've found that - uses: Swatinem/rust-cache@v2 can speed-up CI quite a bit! So if that's something that you are interested in I can open up a PR to measure the difference?

Sure, that would be great

@oeb25 oeb25 mentioned this pull request Jan 3, 2024
Draft
8 tasks
@Lorak-mmk
Copy link
Collaborator

Code change looks good to me now. Could you squash 2 commits that modify CI?

@oeb25
Copy link
Contributor Author

oeb25 commented Jan 3, 2024

Squashed!

Lorak-mmk
Lorak-mmk approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@Lorak-mmk Lorak-mmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @piodul ?

@piodul piodul merged commit 2faeba0 into scylladb:main Jan 3, 2024
8 checks passed
@avelanarius avelanarius added this to the 0.12.0 milestone Jan 15, 2024
@Lorak-mmk Lorak-mmk mentioned this pull request Feb 1, 2024
Closed
@oeb25 oeb25 mentioned this pull request Feb 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piodul piodul piodul approved these changes

@Lorak-mmk Lorak-mmk Lorak-mmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Compile error with --no-default-features -F chrono
4 participants
@oeb25 @Lorak-mmk @piodul @avelanarius