Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect sstablesPerRead values #330

Closed
Deexie opened this issue Apr 18, 2023 · 2 comments
Closed

Incorrect sstablesPerRead values #330

Deexie opened this issue Apr 18, 2023 · 2 comments

Comments

@Deexie
Copy link
Contributor

Deexie commented Apr 18, 2023

TableHistograms::execute(NodeProbe) sets incorrect percentile values
in sstablesPerRead array, causing that nodetool's tablehistogram
shows deceiving SSTables values.
Deexie added a commit to Deexie/scylla-tools-java that referenced this issue Apr 18, 2023
@Deexie
Use original jmx histogram in metricPercentilesAsArray
2bdc06f 
NodeProbe::metricPercentilesAsArray(JmxHistogramMBean) is expected
to return an array with percentiles obtained from a given histogram.
Currently BufferSamples object is created out of the original jmx
histogram's values. BufferSamples::getValue(double) expects data
in different format than the provided one.

The percentiles are obtained from original JmxHistogramMBean with
no indirect classes employed.

Fixes: scylladb#330.
Deexie added a commit to Deexie/scylla-tools-java that referenced this issue Apr 18, 2023
@Deexie
Use original jmx histogram in metricPercentilesAsArray
9eb86fc 
NodeProbe::metricPercentilesAsArray(JmxHistogramMBean) is expected
to return an array with percentiles obtained from a given histogram.
Currently BufferSamples object is created out of the original jmx
histogram's values and its getValue method is used to create an array.
BufferSamples::getValue(double) expects data in different format than
the provided one, though.

The percentiles are obtained from original JmxHistogramMBean with
no indirect classes employed.

Fixes: scylladb#330.
@Deexie Deexie mentioned this issue Apr 18, 2023
Closed
Deexie added a commit to Deexie/scylla-tools-java that referenced this issue Apr 20, 2023
@Deexie
Use EstimatedHistogram in metricPercentilesAsArray
0905f11 
NodeProbe::metricPercentilesAsArray(JmxHistogramMBean) is expected
to return an array with percentiles obtained from a given histogram.
Currently BufferSamples object is created out of the original jmx
histogram's values and its getValue method is used to create an array.
BufferSamples::getValue(double) expects data in different format than
the provided one, though.

EstimatedHistogram, which is compactible with original histogram,
is created out of metric values.

Fixes: scylladb#330.
@denesb denesb closed this as completed in eb3c43f Apr 21, 2023
@bhalevy bhalevy mentioned this issue Jul 31, 2023
Closed
@bhalevy
Copy link
Member

bhalevy commented Jul 31, 2023

@scylladb/scylla-maint please backport to all live branches

@bhalevy
Copy link
Member

bhalevy commented Jul 31, 2023

Cc @DoronArazii

denesb pushed a commit that referenced this issue Jul 31, 2023
@Deexie @denesb
Use EstimatedHistogram in metricPercentilesAsArray
f8f556d 
NodeProbe::metricPercentilesAsArray(JmxHistogramMBean) is expected
to return an array with percentiles obtained from a given histogram.
Currently BufferSamples object is created out of the original jmx
histogram's values and its getValue method is used to create an array.
BufferSamples::getValue(double) expects data in different format than
the provided one, though.

EstimatedHistogram, which is compactible with original histogram,
is created out of metric values.

Fixes: #330.
Closes: #331.
(cherry picked from commit eb3c43f)
denesb pushed a commit that referenced this issue Jul 31, 2023
@Deexie @denesb
Use EstimatedHistogram in metricPercentilesAsArray
be0aaf7 
NodeProbe::metricPercentilesAsArray(JmxHistogramMBean) is expected
to return an array with percentiles obtained from a given histogram.
Currently BufferSamples object is created out of the original jmx
histogram's values and its getValue method is used to create an array.
BufferSamples::getValue(double) expects data in different format than
the provided one, though.

EstimatedHistogram, which is compactible with original histogram,
is created out of metric values.

Fixes: #330.
Closes: #331.
(cherry picked from commit eb3c43f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use EstimatedHistogram in metricPercentilesAsArray(JmxHistogramMBean) Deexie/scylla-tools-java
2 participants
@bhalevy @Deexie