cassandra-stress: pass all hosts straight to the driver #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases of multiple contact points configued from commandline code was randomly selecting one host and pass that to the cql driver if for some reason that specfic node wasn't available the whole command would fail. removing this random, and passing all hosts to the driver fix this issue, and the driver code is more then capble of handling a situation of some contact points unreachable
Bouncheck
approved these changes
Nov 8, 2022
yep, exactly how I checked it too. |
fruch
added a commit
to fruch/scylla-cluster-tests
that referenced
this pull request
Jan 12, 2023
using image from master to avoid issue to start stress when nodes are down that was fixed in scylladb/scylla-tools-java#314
fruch
added a commit
to fruch/scylla-cluster-tests
that referenced
this pull request
Jan 12, 2023
using image from master to avoid issue to start stress when nodes are down that was fixed in scylladb/scylla-tools-java#314
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases of multiple contact points configued from commandline code was randomly selecting one host and pass that to the cql driver if for some reason that specfic node wasn't available the whole command would fail.
removing this random, and passing all hosts to the driver fix this issue, and the driver code is more then capble of handling a situation of some contact points unreachable