-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lwt: assertion in boost::dynamic_bitset on execution of multi table LWT batch. #6332
Closed
1 task done
Comments
@kostja are you aware of this? |
Well, Evgeniy mentioned earlier he hit a crash, I wasn't aware of the specifics. Will take a look. |
alecco
added a commit
to alecco/scylladb
that referenced
this issue
May 14, 2020
Closes scylladb#6332 Tested with https://github.com/scylladb/scylla-dtest/pull/1465 Branch URL: https://github.com/alecco/scylla/tree/fix_issue_6332 Tests: unit ({dev}) Signed-off-by: Alejo Sanchez <alejo.sanchez@scylladb.com>
alecco
added a commit
to alecco/scylladb
that referenced
this issue
May 14, 2020
Closes scylladb#6332 Tested with https://github.com/scylladb/scylla-dtest/pull/1465 Branch URL: https://github.com/alecco/scylla/tree/fix_issue_6332 Tests: unit ({dev}) Signed-off-by: Alejo Sanchez <alejo.sanchez@scylladb.com>
alecco
added a commit
to alecco/scylladb
that referenced
this issue
May 14, 2020
LWT batches conditions can't span multiple tables. This was detected in batch_statement::validate() called in ::prepare(). But ::cas_result_set_metadata() was built in the constructor, causing a bitset assert/crash in a reported scenario. This patch moves validate() to the constructor before building metadata. Closes scylladb#6332 Tested with https://github.com/scylladb/scylla-dtest/pull/1465 Branch URL: https://github.com/alecco/scylla/tree/fix_issue_6332 Tests: unit ({dev}) Signed-off-by: Alejo Sanchez <alejo.sanchez@scylladb.com>
alecco
added a commit
to alecco/scylladb
that referenced
this issue
May 14, 2020
LWT batches conditions can't span multiple tables. This was detected in batch_statement::validate() called in ::prepare(). But ::cas_result_set_metadata() was built in the constructor, causing a bitset assert/crash in a reported scenario. This patch moves validate() to the constructor before building metadata. Closes scylladb#6332 Tested with https://github.com/scylladb/scylla-dtest/pull/1465 Signed-off-by: Alejo Sanchez <alejo.sanchez@scylladb.com>
tgrabiec
added a commit
that referenced
this issue
May 15, 2020
…om Alejo Fix a metadata crash and exception message casing consistency. Fixes #6332. * https://github.com/alecco/scylla/tree/fix_issue_6332: lwt: consistent exception message case lwt: validate before constructing metadata
tgrabiec
added a commit
that referenced
this issue
May 18, 2020
…om Alejo Fix a metadata crash and exception message casing consistency. Fixes #6332 * alejo/fix_issue_6332: lwt: validate before constructing metadata lwt: consistent exception message case
avikivity
pushed a commit
that referenced
this issue
May 19, 2020
…om Alejo Fix a metadata crash and exception message casing consistency. Fixes #6332 * alejo/fix_issue_6332: lwt: validate before constructing metadata lwt: consistent exception message case
@tgrabiec please evaluate for backport |
Seems safe for backporting. Could bring a cluster down when hit, so we probably should backport. |
avikivity
pushed a commit
that referenced
this issue
Jun 21, 2020
LWT batches conditions can't span multiple tables. This was detected in batch_statement::validate() called in ::prepare(). But ::cas_result_set_metadata() was built in the constructor, causing a bitset assert/crash in a reported scenario. This patch moves validate() to the constructor before building metadata. Closes #6332 Tested with scylladb/scylla-dtest#1465 Signed-off-by: Alejo Sanchez <alejo.sanchez@scylladb.com> (cherry picked from commit d1521e6)
avikivity
pushed a commit
that referenced
this issue
Jun 21, 2020
LWT batches conditions can't span multiple tables. This was detected in batch_statement::validate() called in ::prepare(). But ::cas_result_set_metadata() was built in the constructor, causing a bitset assert/crash in a reported scenario. This patch moves validate() to the constructor before building metadata. Closes #6332 Tested with scylladb/scylla-dtest#1465 Signed-off-by: Alejo Sanchez <alejo.sanchez@scylladb.com> (cherry picked from commit d1521e6)
Backported to 4.0, 4.1. |
avikivity
pushed a commit
that referenced
this issue
Jun 21, 2020
LWT batches conditions can't span multiple tables. This was detected in batch_statement::validate() called in ::prepare(). But ::cas_result_set_metadata() was built in the constructor, causing a bitset assert/crash in a reported scenario. This patch moves validate() to the constructor before building metadata. Closes #6332 Tested with scylladb/scylla-dtest#1465 [avi: adjust spelling of exception message to 4.1 spelling] Signed-off-by: Alejo Sanchez <alejo.sanchez@scylladb.com> (cherry picked from commit d1521e6)
avikivity
pushed a commit
that referenced
this issue
Jun 21, 2020
LWT batches conditions can't span multiple tables. This was detected in batch_statement::validate() called in ::prepare(). But ::cas_result_set_metadata() was built in the constructor, causing a bitset assert/crash in a reported scenario. This patch moves validate() to the constructor before building metadata. Closes #6332 Tested with scylladb/scylla-dtest#1465 [avi: adjust spelling of exception message to 4.0 spelling] Signed-off-by: Alejo Sanchez <alejo.sanchez@scylladb.com> (cherry picked from commit d1521e6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is Scylla's bug tracker, to be used for reporting bugs only.
If you have a question about Scylla, and not a bug, please ask it in
our mailing-list at scylladb-dev@googlegroups.com or in our slack channel.
Installation details
Scylla version (or git commit hash): 4.0.rc2
Cluster size: 1
OS (RHEL/CentOS/Ubuntu/AWS AMI): Ubuntu
Trying to make following CQL and instead of syntax error got assertion:
Assertion:
The text was updated successfully, but these errors were encountered: