Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repair: inaccurate log from check_failed_ranges #6785

Closed
asias opened this issue Jul 7, 2020 · 1 comment
Closed

repair: inaccurate log from check_failed_ranges #6785

asias opened this issue Jul 7, 2020 · 1 comment

Comments

@asias
Copy link
Contributor

asias commented Jul 7, 2020

When a repair fails we see log like:

format("repair {:d} on shard {:d} failed to do checksum for {:d} sub ranges", id, shard, nr_failed_ranges)

This is inaccurate because the error for the failure can be other reasons than checksum failure.
asias added a commit to asias/scylla that referenced this issue Jul 7, 2020
@asias
repair: Fix inaccurate in check_failed_ranges
cfab2ad 
The reason for the failure can be other reasons than failure of
checksum.

Fixes scylladb#6785
@asias asias mentioned this issue Jul 7, 2020
Closed
avikivity pushed a commit that referenced this issue Jul 7, 2020
@asias @avikivity
repair: Fix inaccurate exception message in check_failed_ranges
75efdfd 
The reason for the failure can be other reasons than failure of
checksum.

Fixes #6785
avikivity pushed a commit that referenced this issue Jul 7, 2020
@asias @avikivity
repair: Fix inaccurate exception message in check_failed_ranges
9c4a331 
The reason for the failure can be other reasons than failure of
checksum.

Fixes #6785
@avikivity
Copy link
Member

Minor, not backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asias @avikivity @scylladb-promoter