Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build scylla-unified tarball as part of "dist" target #6949

Closed
penberg opened this issue Jul 29, 2020 · 0 comments
Closed

Build scylla-unified tarball as part of "dist" target #6949

penberg opened this issue Jul 29, 2020 · 0 comments
Assignees
Milestone

Comments

@penberg
Copy link
Contributor

penberg commented Jul 29, 2020

There's a unified/build_unified.sh script to build unified tarball, but we need to make it as part of the dist target in ninja.

@slivne slivne added this to the 4.3 milestone Jul 30, 2020
avikivity added a commit that referenced this issue Sep 14, 2020
"
This pull request fixes unified relocatable package dependency issues in
other build modes than release, and then adds unified tarball to the
"dist" build target.

Fixes #6949
"

* 'penberg/build/unified-to-dist/v1' of github.com:penberg/scylla:
  configure.py: Build unified tarball as part of "dist" target
  unified/build_unified: Use build/<mode>/dist/tar for dependency tarballs
  configure.py: Use build/<mode>/dist/tar for unified tarball dependencies
avikivity added a commit that referenced this issue Sep 14, 2020
"
This pull request fixes unified relocatable package dependency issues in
other build modes than release, and then adds unified tarball to the
"dist" build target.

Fixes #6949
"

* 'penberg/build/unified-to-dist/v1' of github.com:penberg/scylla:
  configure.py: Build unified tarball as part of "dist" target
  unified/build_unified: Use build/<mode>/dist/tar for dependency tarballs
  configure.py: Use build/<mode>/dist/tar for unified tarball dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants