Make sure that secondary indexes created before 3.2 have their idx_token column correctly marked as computed
#7515
Comments
psarna
added a commit
to psarna/scylla
that referenced
this issue
Oct 31, 2020
If an index was created before 3.2, its special `idx_token` column is not properly marked as computed. In order for this column to be treated as a computed column, schema of all secondary indexes is checked and fixed. Fixes scylladb#7515 Tests: unit(dev)
psarna
added a commit
to psarna/scylla
that referenced
this issue
Nov 2, 2020
Old secondary index schemas did not have their idx_token column marked as computed, and there already exists code which updates them. Unfortunately, the fix itself contains an error and doesn't fire if computed columns are not yet supported by the whole cluster, which is a very common situation during upgrades. Fixes scylladb#7515
avikivity
pushed a commit
that referenced
this issue
Nov 5, 2020
Old secondary index schemas did not have their idx_token column marked as computed, and there already exists code which updates them. Unfortunately, the fix itself contains an error and doesn't fire if computed columns are not yet supported by the whole cluster, which is a very common situation during upgrades. Fixes #7515 Closes #7516 (cherry picked from commit b66c285)
avikivity
pushed a commit
that referenced
this issue
Nov 5, 2020
Old secondary index schemas did not have their idx_token column marked as computed, and there already exists code which updates them. Unfortunately, the fix itself contains an error and doesn't fire if computed columns are not yet supported by the whole cluster, which is a very common situation during upgrades. Fixes #7515 Closes #7516 (cherry picked from commit b66c285)
avikivity
pushed a commit
that referenced
this issue
Nov 5, 2020
Old secondary index schemas did not have their idx_token column marked as computed, and there already exists code which updates them. Unfortunately, the fix itself contains an error and doesn't fire if computed columns are not yet supported by the whole cluster, which is a very common situation during upgrades. Fixes #7515 Closes #7516 (cherry picked from commit b66c285)
|
Backported to 4.1, 4.2, 4.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Before 3.2, the
idx_tokencolumn was a special case column, computed on the go from the values of the partition key. Since 3.2, this computation was abstracted to a notion of computed columns. We should make sure that each secondary index created before the change has its schema correctly updated, i.e. itsidx_tokencolumn must be properly marked as computed.The text was updated successfully, but these errors were encountered: