Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description in scylla-fstrim.timer is incorrect #8633

Closed
rajeshahuja-bsft opened this issue May 11, 2021 · 2 comments
Closed

Description in scylla-fstrim.timer is incorrect #8633

rajeshahuja-bsft opened this issue May 11, 2021 · 2 comments
Labels
user request
Milestone
4.6

Comments

@rajeshahuja-bsft
Copy link

Installation details
Scylla version (or git commit hash): 2020.1.7-0.20210304.e42189e09
Cluster size: 18
OS (RHEL/CentOS/Ubuntu/AWS AMI): Ubuntu 16.04

The description inside Unit section says timer is executed daily.
Ref: https://github.com/scylladb/scylla/blob/121eb32679a2c8850cfec057dad9c81171adcb93/dist/common/systemd/scylla-fstrim.timer
However the actual timer is set to run it weekly every Saturday.

Please fix the description in systemd unit file.
@nyh
Copy link
Contributor

nyh commented May 11, 2021

CC @syuu1228

syuu1228 added a commit to syuu1228/scylla that referenced this issue May 12, 2021
@syuu1228
scylla-fstrim.timer: fix wrong description from 'daily' to 'weekly'
87c3087 
It scheduled weekly, not daily.

Fixes scylladb#8633
@syuu1228 syuu1228 mentioned this issue May 12, 2021
Closed
avikivity pushed a commit that referenced this issue May 13, 2021
@syuu1228 @avikivity
scylla-fstrim.timer: fix wrong description from 'daily' to 'weekly'
12774d1 
It scheduled weekly, not daily.

Fixes #8633

Closes #8644
@avikivity
Copy link
Member

Minor doc bug, not backporting.

@DoronArazii DoronArazii added this to the 4.6 milestone May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
user request
Projects
None yet
Milestone
4.6
Development

No branches or pull requests
5 participants
@nyh @avikivity @scylladb-promoter @rajeshahuja-bsft @DoronArazii