Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support CRL with server/client encryption options #9630

Closed
ajmaidak opened this issue Nov 15, 2021 · 3 comments
Closed

support CRL with server/client encryption options #9630

ajmaidak opened this issue Nov 15, 2021 · 3 comments

Comments

@ajmaidak
Copy link

Best I can tell scylla doesn't support a certificate revocation list for either server or client encryption options. Thus if a TLS client private key is leaked you would need to remove the signing CA from the trust store to decline connections from clients using that certificate. Ideally you would append the leaked clients certificate the CRL instead.

It would be a good enhancement to support providing a CRL file argument to the client_encryption_options and server_encryption_options configuration hashes, like:

client_encryption_options:
    enabled: True
    certificate: conf/scylla.crt
    keyfile: conf/scylla.key
    truststore: conf/truststore.pem
    certficate_revocation_list: conf/revoked-certs.crl
    require_client_auth: True
@avikivity
Copy link
Member

/cc @elcallio

@elcallio
Copy link
Contributor

https://www.gnutls.org/manual/html_node/PKIX-certificate-revocation-lists.html

Relatively easy to implement, though if it is gonna match everything else, it should have an auto-reload sibling, and a number of adapting versions similar to certs/keys.

elcallio pushed a commit to elcallio/scylla that referenced this issue Nov 17, 2021
…on options

Fixes scylladb#9630

Adds support for importing a CRL certificate reovcation list. This will be
monitored and reloaded like certs/keys. Allows blacklisting individual certs.
@elcallio
Copy link
Contributor

Turns out I had already written the code in seastar from the get-go. Only need to add scylla support in config.

elcallio pushed a commit to elcallio/scylla that referenced this issue Nov 17, 2021
…on options

Fixes scylladb#9630

Adds support for importing a CRL certificate reovcation list. This will be
monitored and reloaded like certs/keys. Allows blacklisting individual certs.

v2:
* Include option in template config in scylla.yaml
* Change <empty> to <none>
@DoronArazii DoronArazii added this to the 5.0 milestone Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants