Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
In commit 7eda6b1, we increased the request_timeout parameter used by cql-pytest tests from the default of 10 seconds to 120 seconds. 10 seconds was usually more than enough for finishing any Scylla request, but it turned out that in some extreme cases of a debug build running on an extremely over-committed machine, the default timeout was not enough. Recently, in issue #11289 we saw additional cases of timeouts which the request_timeout setting did *not* solve. It turns out that the Python CQL driver has two additional timeout settings - connect_timeout and control_connection_timeout, which default to 5 seconds and 2 seconds respectively. I believe that most of the timeouts in issue #11289 come from the control_connection_timeout setting - by changing it to a tiny number (e.g., 0.0001) I got the same error messages as those reported in #11289. The default of that timeout - 2 seconds - is certainly low enough to be reached on an extremely over-committed machine. So this patch significantly increases both connect_timeout and control_connection_timeout to 60 seconds. We don't care that this timeout is ridiculously large - under normal operations it will never be reached. There is no code which loops for this amount of time, for example. Refs #11289 (perhaps even Fixes, we'll need to see that the test errors go away). NOTE: This patch only changes test/cql-pytest/util.py, which is only used by the cql-pytest test suite. We have multiple other test suites which copied this code, and those test suites might need fixing separately. Signed-off-by: Nadav Har'El <nyh@scylladb.com> Closes #11295
- Loading branch information