test: move random string helpers to .cc

... since there's no reason for them to reside in a header,
and .cc is our default destination.

Message-Id: <2509410f0f71df036a7829f1f799503c1a671404.1591078777.git.sarna@scylladb.com>

test/lib/make_random_string.hh

@@ -25,26 +25,6 @@
 
 #include <seastar/core/sstring.hh>
 #include "seastarx.hh"
-#include <random>
 
-inline
-sstring make_random_string(size_t size) {
-    static thread_local std::default_random_engine rng;
-    std::uniform_int_distribution<char> dist;
-    sstring str = uninitialized_string(size);
-    for (auto&& b : str) {
-        b = dist(rng);
-    }
-    return str;
-}
-
-inline
-sstring make_random_numeric_string(size_t size) {
-    static thread_local std::default_random_engine rng;
-    std::uniform_int_distribution<char> dist('0', '9');
-    sstring str = uninitialized_string(size);
-    for (auto&& b : str) {
-        b = dist(rng);
-    }
-    return str;
-}
+sstring make_random_string(size_t size);
+sstring make_random_numeric_string(size_t size);

test/lib/test_utils.cc

@@ -26,6 +26,7 @@
 #include "test/lib/log.hh"
 
 #include "seastarx.hh"
+#include <random>
 
 namespace tests {
 
@@ -59,3 +60,23 @@ void fail(std::string_view msg, std::experimental::source_location sl) {
 }
 
 }
+
+sstring make_random_string(size_t size) {
+    static thread_local std::default_random_engine rng;
+    std::uniform_int_distribution<char> dist;
+    sstring str = uninitialized_string(size);
+    for (auto&& b : str) {
+        b = dist(rng);
+    }
+    return str;
+}
+
+sstring make_random_numeric_string(size_t size) {
+    static thread_local std::default_random_engine rng;
+    std::uniform_int_distribution<char> dist('0', '9');
+    sstring str = uninitialized_string(size);
+    for (auto&& b : str) {
+        b = dist(rng);
+    }
+    return str;
+}