Skip to content

Commit

Permalink
streaming: cast the progress to a float before formatting it
Browse files Browse the repository at this point in the history
before this change, we format a `long` using `{:f}`. fmtlib would
throw an exception when actually formatting it.

so, let's make the percentage a float before formatting it.

Fixes #14587
Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>

Closes #14588
  • Loading branch information
tchaikov authored and avikivity committed Jul 9, 2023
1 parent 894039d commit 1eb76d9
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions streaming/progress_info.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@ namespace streaming {

std::ostream& operator<<(std::ostream& os, const progress_info& x) {
sstring dir = x.dir == progress_info::direction::OUT ? "sent to " : "received from ";
return os << format("{} {:d}/({:f}%) {} {}", x.file_name, x.current_bytes,
x.current_bytes * 100 / x.total_bytes, dir, x.peer);
fmt::print(os, "{} {:d}/({:f}%) {} {}", x.file_name, x.current_bytes,
x.current_bytes * 100.F / x.total_bytes, dir, x.peer);
return os;
}

}

0 comments on commit 1eb76d9

Please sign in to comment.