Skip to content

Commit

Permalink
migration_manager: Propagate schema changes with reads like we do on …
Browse files Browse the repository at this point in the history
…writes

This fixes the problem where the cordinator already knows about the
new schema and issues a read which uses new objects, but the replica
doesn't know those objects yet. The read will fail in this case. We
can avoid this if we propagate schema changes with reads, like we
already do for writes.

Message-Id: <20210205163422.414275-1-tgrabiec@scylladb.com>
  • Loading branch information
tgrabiec authored and avikivity committed Feb 8, 2021
1 parent 4082f57 commit c16e4a0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion service/migration_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1092,7 +1092,7 @@ future<schema_ptr> get_schema_definition(table_schema_version v, netw::messaging
}

future<schema_ptr> get_schema_for_read(table_schema_version v, netw::messaging_service::msg_addr dst, netw::messaging_service& ms) {
return get_schema_definition(v, dst, ms);
return get_schema_for_write(v, dst, ms);
}

future<schema_ptr> get_schema_for_write(table_schema_version v, netw::messaging_service::msg_addr dst, netw::messaging_service& ms) {
Expand Down

0 comments on commit c16e4a0

Please sign in to comment.