Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distributed loader prioritized keyspaces has been removed. Breaks enterprise #11349

Closed
elcallio opened this issue Aug 22, 2022 · 3 comments · Fixed by #11350
Closed

Distributed loader prioritized keyspaces has been removed. Breaks enterprise #11349

elcallio opened this issue Aug 22, 2022 · 3 comments · Fixed by #11350
Assignees
@elcallio
Milestone
5.2

Comments

@elcallio
Copy link
Contributor

In 7396de7 (and refactorings before it) the set of prioritized keyspaces (and processing thereof) was removed, due to apparent non-usage (which is true for open-source version).

This functionality is however required for certain features of the enterprise version (ear). As such is needs to be restored and reenabled.
@elcallio elcallio self-assigned this Aug 22, 2022
elcallio pushed a commit to elcallio/scylla that referenced this issue Aug 22, 2022
distributed_loader: Restore separate processing of keyspace init prio…
e58a526 
…/normal

Fixes scylladb#11349

In 7396de7 (and refactorings before it) the set of prioritized keyspaces (and processing thereof)
was removed, due to apparent non-usage (which is true for open-source version).

This functionality is however required for certain features of the enterprise version (ear).
As such is needs to be restored and reenabled. This patch and revert before it does so, adapted
to the recent version of this file.
@elcallio elcallio mentioned this issue Aug 22, 2022
Merged
avikivity added a commit that referenced this issue Aug 23, 2022
@avikivity
Merge 'distributed_loader: Restore separate processing of keyspace in…
fd9d8dd 
…it prio/normal' from Calle Wilund

Fixes #11349

In 7396de7 (and refactorings before it) the set of prioritized keyspaces (and processing thereof)
was removed, due to apparent non-usage (which is true for open-source version).

This functionality is however required for certain features of the enterprise version (ear).
As such is needs to be restored and reenabled. This patch set does so, adapted
to the recent version of this file.

Closes #11350

* github.com:scylladb/scylladb:
  distributed_loader: Restore separate processing of keyspace init prio/normal
  Revert "distributed_loader: Remove unused load-prio manipulations"
@avikivity
Copy link
Member

@elcallio do we need to backport it to any branch?

@elcallio
Copy link
Contributor Author

elcallio commented Oct 3, 2022

If possible, it should be backported to 2021.x, where the feature was both introduced and apparently (accidentality) removed. Not sure if the code is compatible though. Or we can consider replicated key provider an outlier and not backport for things like that...?

@DoronArazii DoronArazii added this to the 5.2 milestone Nov 16, 2022
@avikivity
Copy link
Member

Not affecting any release, not backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elcallio elcallio

Labels
None yet
Projects
None yet
Milestone
5.2
Development

Successfully merging a pull request may close this issue.

distributed_loader: Restore separate processing of keyspace init prio/normal elcallio/scylla
4 participants
@avikivity @elcallio @scylladb-promoter @DoronArazii