token_metadata:is_member should not depend on topology #11935
Milestone
Comments
asias
added a commit
to asias/scylla
that referenced
this issue
Nov 9, 2022
Since commit a980f94 (token_metadata: impl: keep the set of normal token owners as a member), we have a set, _normal_token_owners, which contains all the nodes in the ring. We can use _normal_token_owners to check if a node is part of the ring directly instead of going through the _toplogy indirectly. Fixes scylladb#11935
asias
added a commit
to asias/scylla
that referenced
this issue
Nov 9, 2022
Since commit a980f94 (token_metadata: impl: keep the set of normal token owners as a member), we have a set, _normal_token_owners, which contains all the nodes in the ring. We can use _normal_token_owners to check if a node is part of the ring directly instead of going through the _toplogy indirectly. Fixes scylladb#11935
bhalevy
pushed a commit
to bhalevy/scylla
that referenced
this issue
Nov 14, 2022
Since commit a980f94 (token_metadata: impl: keep the set of normal token owners as a member), we have a set, _normal_token_owners, which contains all the nodes in the ring. We can use _normal_token_owners to check if a node is part of the ring directly instead of going through the _toplogy indirectly. Fixes scylladb#11935
bhalevy
pushed a commit
to bhalevy/scylla
that referenced
this issue
Nov 15, 2022
Since commit a980f94 (token_metadata: impl: keep the set of normal token owners as a member), we have a set, _normal_token_owners, which contains all the nodes in the ring. We can use _normal_token_owners to check if a node is part of the ring directly instead of going through the _toplogy indirectly. Fixes scylladb#11935
bhalevy
pushed a commit
to bhalevy/scylla
that referenced
this issue
Nov 16, 2022
Since commit a980f94 (token_metadata: impl: keep the set of normal token owners as a member), we have a set, _normal_token_owners, which contains all the nodes in the ring. We can use _normal_token_owners to check if a node is part of the ring directly instead of going through the _toplogy indirectly. Fixes scylladb#11935
bhalevy
pushed a commit
to bhalevy/scylla
that referenced
this issue
Nov 16, 2022
Since commit a980f94 (token_metadata: impl: keep the set of normal token owners as a member), we have a set, _normal_token_owners, which contains all the nodes in the ring. We can use _normal_token_owners to check if a node is part of the ring directly instead of going through the _toplogy indirectly. Fixes scylladb#11935
xemul
added a commit
that referenced
this issue
Nov 18, 2022
…from Asias He Since commit a980f94 (token_metadata: impl: keep the set of normal token owners as a member), we have a set, _normal_token_owners, which contains all the nodes in the ring. We can use _normal_token_owners to check if a node is part of the ring directly instead of going through the _toplogy indirectly. Fixes #11935 Closes #11936 * github.com:scylladb/scylladb: token_metadata: Rename is_member to is_normal_token_owner token_metadata: Add docs for is_member token_metadata: Do not use topology info for is_member check token_metadata: Check node is part of the topology instead of the ring
|
@asias from the description it looks like it doesn't directly fix a bug and therefore needs no backport. Is this correct? |
Correct. |
|
Not a bug, not backporting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The topology is about rack and dc. The is_member is about if the node is part of the token ring. We should check is_member with the token ring info directly.
The text was updated successfully, but these errors were encountered: