Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use-after-move in virtual table for secondary indexes #13396

Closed
raphaelsc opened this issue Mar 31, 2023 · 1 comment
Closed

Use-after-move in virtual table for secondary indexes #13396

raphaelsc opened this issue Mar 31, 2023 · 1 comment
Assignees
@raphaelsc
Milestone
5.3

Comments

@raphaelsc
Copy link
Member

That's courtersy of raphaelsc/seastar@153813d.

Report:
./index/built_indexes_virtual_reader.hh:228:40: warning: invalid invocation of method 'operator->' on object 's' while it is in the 'consumed' state [-Wconsumed]
_db.find_column_family(s->ks_name(), system_keyspace::v3::BUILT_VIEWS),
@raphaelsc raphaelsc self-assigned this Mar 31, 2023
@DoronArazii DoronArazii added this to the 5.3 milestone May 1, 2023
avikivity pushed a commit that referenced this issue May 15, 2023
@raphaelsc @avikivity
index/built_indexes_virtual_reader.hh: Fix use-after-move
874062b 
static report:
./index/built_indexes_virtual_reader.hh:228:40: warning: invalid invocation of method 'operator->' on object 's' while it is in the 'consumed' state [-Wconsumed]
                _db.find_column_family(s->ks_name(), system_keyspace::v3::BUILT_VIEWS),

Fixes #13396.

Signed-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com>
(cherry picked from commit f8df3c7)
avikivity pushed a commit that referenced this issue May 15, 2023
@raphaelsc @avikivity
index/built_indexes_virtual_reader.hh: Fix use-after-move
f1ee68e 
static report:
./index/built_indexes_virtual_reader.hh:228:40: warning: invalid invocation of method 'operator->' on object 's' while it is in the 'consumed' state [-Wconsumed]
                _db.find_column_family(s->ks_name(), system_keyspace::v3::BUILT_VIEWS),

Fixes #13396.

Signed-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com>
(cherry picked from commit f8df3c7)
@avikivity
Copy link
Member

Backported to 5.1, 5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raphaelsc raphaelsc

Labels
None yet
Projects
None yet
Milestone
5.3
Development

No branches or pull requests
5 participants
@avikivity @denesb @raphaelsc @scylladb-promoter @DoronArazii