Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compaction shares are unnecessarily bumped during major compaction #13487

Closed
raphaelsc opened this issue Apr 12, 2023 · 2 comments
Closed

Compaction shares are unnecessarily bumped during major compaction #13487

raphaelsc opened this issue Apr 12, 2023 · 2 comments
Assignees
@raphaelsc
Milestone
5.3

Comments

@raphaelsc
Copy link
Member

Commit 49892a0, back in 2018, bumps the compaction shares by 200 to guarantee a minimum base line.

However, after commit e3f561d, major compaction runs in maintenance group meaning that bumping shares became completely irrelevant and only causes regular compaction to be unnecessarily more aggressive.
@raphaelsc raphaelsc self-assigned this Apr 12, 2023
@raphaelsc
Copy link
Member Author

FYI @bhalevy

raphaelsc added a commit to raphaelsc/scylla that referenced this issue Apr 12, 2023
@raphaelsc
compaction: Don't bump compaction shares during major execution
f7b3e8f 
Commit 49892a0, back in 2018, bumps the compaction shares by 200 to
guarantee a minimum base line.

However, after commit e3f561d, major compaction runs in maintenance
group meaning that bumping shares became completely irrelevant and
only causes regular compaction to be unnecessarily more aggressive.

Fixes scylladb#13487.

Signed-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com>
@raphaelsc raphaelsc mentioned this issue Apr 12, 2023
Closed
@avikivity
Copy link
Member

Not a regression, not backporting.

@DoronArazii DoronArazii added this to the 5.3 milestone May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raphaelsc raphaelsc

Labels
None yet
Projects
None yet
Milestone
5.3
Development

Successfully merging a pull request may close this issue.

compaction: Don't bump compaction shares during major execution raphaelsc/scylla
4 participants
@avikivity @raphaelsc @scylladb-promoter @DoronArazii